Skip to content

std: merge sys::pal::common and sys_common into sys::helpers #150047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joboet wants to merge 5 commits into
base: main
Choose a base branch
from
Open

std: merge sys::pal::common and sys_common into sys::helpers #150047

joboet wants to merge 5 commits into from

Conversation

@joboet
Copy link
Member

@joboet joboet commented Dec 16, 2025 •
edited by rustbot
Loading

As per #117276, this removes sys_common and moves its functionality and that of sys::pal::common into a newly created sys::helpers module.

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-tidy Area: The tidy tool O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2025
@joboet joboet mentioned this pull request Dec 16, 2025
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
fbstj
fbstj reviewed Dec 16, 2025
View reviewed changes
@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2025

The Miri subtree was changed

cc @rust-lang/miri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fbstj fbstj fbstj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-tidy Area: The tidy tool O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joboet @rustbot @rust-log-analyzer @fbstj @Mark-Simulacrum