Improve code suggestion for incorrect macro_rules! usage by chenyukang · Pull Request #150988 · rust-lang/rust

chenyukang · 2026-01-12T05:06:39Z

rustbot · 2026-01-12T05:06:44Z

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/ui/macros/issue-118786.stderr

chenyukang · 2026-01-12T08:07:57Z

@bors try jobs=x86_64-gnu-tools

…try> Improve code suggestion for incorrect macro_rules! usage try-job: x86_64-gnu-tools

rust-bors · 2026-01-12T09:14:38Z

☀️ Try build successful (CI)
Build commit: 1e976b1 (1e976b1323de0dab3e87fb93cb0f6a3bf75847bd, parent: 840245e91b90f22adf9f26d0a0cd98c2416cdef3)

chenyukang · 2026-01-12T10:59:54Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

............................................       (144/144)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 255: expected 0 elements, found 1: for command `assert-count: ("//*[@class='tooltip popover']", 0)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

seems the test is not stable, retry it succeed.

chenyukang · 2026-02-01T03:13:40Z

r? compiler

mati865

I'm not familiar with diagnostics, maybe next reviewer has better insight here @rustbot reroll.

View changes since this review

tests/ui/macros/issue-118786.fixed

compiler/rustc_parse/src/parser/item.rs

petrochenkov · 2026-02-09T15:40:43Z

r=me with the cleanup applied.

rustbot · 2026-02-12T07:32:39Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

chenyukang · 2026-02-12T09:18:06Z

@bors r=petrochenkov

rust-bors · 2026-02-12T09:18:09Z

📌 Commit caf7cdf has been approved by petrochenkov

It is now in the queue for this repository.

…-rules, r=petrochenkov Improve code suggestion for incorrect macro_rules! usage Fixes rust-lang#150899

…uwer Rollup of 11 pull requests Successful merges: - #146901 (Support AVRTiny devices in AVR inline assembly) - #150988 (Improve code suggestion for incorrect macro_rules! usage) - #152422 (Change query proc macro to be more rust-analyzer friendly) - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto) - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`) - #152528 (Support serializing CodegenContext) - #152082 (Move tests) - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion) - #152486 (remove redundant backchain attribute in codegen) - #152529 (sparc64: enable abi compatibility test) - #152548 (reject inline const patterns pre-expansion)

…-rules, r=petrochenkov Improve code suggestion for incorrect macro_rules! usage Fixes rust-lang#150899

Rollup of 18 pull requests Successful merges: - #150551 (Compute localized outlives constraints lazily) - #150752 (Update libc to v0.2.181) - #150988 (Improve code suggestion for incorrect macro_rules! usage) - #152422 (Change query proc macro to be more rust-analyzer friendly) - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto) - #152514 (Collect active query jobs into struct `QueryJobMap`) - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`) - #152528 (Support serializing CodegenContext) - #152082 (Move tests) - #152232 (Add must_use for FileTimes) - #152329 (Simplify parallel! macro) - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion) - #152486 (remove redundant backchain attribute in codegen) - #152519 (Fix feature gating for new `try bikeshed` expressions) - #152529 (sparc64: enable abi compatibility test) - #152548 (reject inline const patterns pre-expansion) - #152550 (Port #[prelude_import] to the attribute parser) - #152552 (Add 2048-bit HvxVectorPair support to Hexagon SIMD ABI checks)

Rollup of 17 pull requests Successful merges: - #150551 (Compute localized outlives constraints lazily) - #150988 (Improve code suggestion for incorrect macro_rules! usage) - #152422 (Change query proc macro to be more rust-analyzer friendly) - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto) - #152514 (Collect active query jobs into struct `QueryJobMap`) - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`) - #152528 (Support serializing CodegenContext) - #152082 (Move tests) - #152232 (Add must_use for FileTimes) - #152329 (Simplify parallel! macro) - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion) - #152486 (remove redundant backchain attribute in codegen) - #152519 (Fix feature gating for new `try bikeshed` expressions) - #152529 (sparc64: enable abi compatibility test) - #152548 (reject inline const patterns pre-expansion) - #152550 (Port #[prelude_import] to the attribute parser) - #152552 (Add 2048-bit HvxVectorPair support to Hexagon SIMD ABI checks) Failed merges: - #152515 (Extract `DepKindVTable` constructors to their own module)

Rollup merge of #150988 - chenyukang:yukang-fix-150899-macro-rules, r=petrochenkov Improve code suggestion for incorrect macro_rules! usage Fixes #150899

rustbot assigned SparrowLii Jan 12, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 12, 2026

chenyukang commented Jan 12, 2026

View reviewed changes

tests/ui/macros/issue-118786.stderr Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jan 12, 2026

Auto merge of #150988 - chenyukang:yukang-fix-150899-macro-rules, r=<…

1e976b1

…try> Improve code suggestion for incorrect macro_rules! usage try-job: x86_64-gnu-tools

This comment has been minimized.

Sign in to view

chenyukang force-pushed the yukang-fix-150899-macro-rules branch from 47f0180 to 16bc545 Compare January 12, 2026 11:01

jieyouxu mentioned this pull request Jan 12, 2026

tests/rustdoc-gui/notable-trait.goml is sometimes flaky #151006

Closed

chenyukang force-pushed the yukang-fix-150899-macro-rules branch from 16bc545 to 1b20dfe Compare January 31, 2026 06:37

rustbot assigned mati865 and unassigned SparrowLii Feb 1, 2026

mati865 reviewed Feb 3, 2026

View reviewed changes

tests/ui/macros/issue-118786.fixed Outdated Show resolved Hide resolved

compiler/rustc_parse/src/parser/item.rs Outdated Show resolved Hide resolved

rustbot assigned petrochenkov and unassigned mati865 Feb 3, 2026

chenyukang force-pushed the yukang-fix-150899-macro-rules branch 2 times, most recently from 03210ea to baa5aca Compare February 3, 2026 12:19

petrochenkov reviewed Feb 9, 2026

View reviewed changes

compiler/rustc_parse/src/parser/item.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026

Improve code suggestion for incorrect macro_rules! usage

caf7cdf

chenyukang force-pushed the yukang-fix-150899-macro-rules branch from baa5aca to caf7cdf Compare February 12, 2026 07:32

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 12, 2026

Rollup merge of rust-lang#150988 - chenyukang:yukang-fix-150899-macro…

82881e4

…-rules, r=petrochenkov Improve code suggestion for incorrect macro_rules! usage Fixes rust-lang#150899

JonathanBrouwer mentioned this pull request Feb 12, 2026

Rollup of 9 pull requests #152547

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 12, 2026

Rollup merge of rust-lang#150988 - chenyukang:yukang-fix-150899-macro…

1bc462b

…-rules, r=petrochenkov Improve code suggestion for incorrect macro_rules! usage Fixes rust-lang#150899

JonathanBrouwer mentioned this pull request Feb 12, 2026

Rollup of 11 pull requests #152551

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 13, 2026

Rollup merge of rust-lang#150988 - chenyukang:yukang-fix-150899-macro…

eed6d86

…-rules, r=petrochenkov Improve code suggestion for incorrect macro_rules! usage Fixes rust-lang#150899

Zalathar mentioned this pull request Feb 13, 2026

Rollup of 18 pull requests #152560

Closed

Zalathar mentioned this pull request Feb 13, 2026

Rollup of 17 pull requests #152562

Merged

rust-bors bot merged commit 6c2700b into rust-lang:main Feb 13, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 13, 2026

rust-timer added a commit that referenced this pull request Feb 13, 2026

Unrolled build for #150988

3e61714

Rollup merge of #150988 - chenyukang:yukang-fix-150899-macro-rules, r=petrochenkov Improve code suggestion for incorrect macro_rules! usage Fixes #150899

Uh oh!

Conversation

chenyukang commented Jan 12, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 12, 2026

Uh oh!

Uh oh!

This comment has been minimized.

chenyukang commented Jan 12, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 12, 2026

Uh oh!

chenyukang commented Jan 12, 2026

Uh oh!

chenyukang commented Feb 1, 2026

Uh oh!

mati865 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Feb 9, 2026

Uh oh!

rustbot commented Feb 12, 2026

Uh oh!

chenyukang commented Feb 12, 2026

Uh oh!

rust-bors bot commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chenyukang commented Jan 12, 2026 •

edited by rustbot

Loading

mati865 left a comment •

edited

Loading