-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Add regression test for #90815 and improve panicking() docs
#151675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Airyshtoteles
wants to merge
3
commits into
rust-lang:main
Choose a base branch
from
Airyshtoteles:fix-issues-90815-151458
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add regression test for #90815 and improve panicking() docs
#151675
Airyshtoteles
wants to merge
3
commits into
rust-lang:main
from
Airyshtoteles:fix-issues-90815-151458
+84
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
This comment has been minimized.
This comment has been minimized.
6554fae to
4b2c9cd
Compare
4b2c9cd to
83ff440
Compare
This comment has been minimized.
This comment has been minimized.
83ff440 to
0a1f171
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes:
1. Regression test for #90815
Adds a test to verify that rustc properly handles the case when inline assembly requests more registers than available (emitting an error instead of crashing with SIGSEGV). The underlying issue was fixed in LLVM.
2. Documentation improvement for #151458
Updates the documentation for
std::thread::panicking()to clarify that it returnstrueboth during unwinding (panic = "unwind") and during the execution of the panic hook (panic = "abort").Fixes #90815
Partially addresses #151458 (documentation aspect)