rustdoc: assoc const bounds from supertraits #151686
Open
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use |
This comment has been minimized.
This comment has been minimized.
cachebag
force-pushed
the
master
branch
2 times, most recently
from
4f2ef15 to
9f1aecd
Compare
When documenting code with associated const equality bounds where the const is defined in a supertrait, `rustdoc` would panic with "called `Option::unwrap()` on a `None` value" because it only searched for the associated item in the immediate trait. This can be fixed by adding a recursive helper function that searched through the traits supertrait hierarchy to find the associated item.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
fmease
reviewed
Jan 26, 2026
| .map(|item| item.def_id); | ||
| let assoc_item = | ||
| find_assoc_item_in_trait(cx.tcx, trait_did, constraint.ident, assoc_tag); | ||
| AssocItemConstraintKind::Equality { term: clean_hir_term(assoc_item, term, cx) } |
Member
There was a problem hiding this comment.
I'm somewhat surprised that cleaning HIR terms cleans the middle representation of consts. If we didn't we wouldn't need to do all this searching (essentially mimicking rustc's HIR ty lowering in a more fragile manner).
Contributor
Author
There was a problem hiding this comment.
We could defer the const middle representation conversion until later in the pipeline? But idk if that would touch too many other parts of rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When documenting code with associated const equality bounds where the const is defined in a supertrait,
rustdocwould panic with "calledOption::unwrap()on aNonevalue" because it only searched for the associated item in the immediate trait.This can be fixed by adding a recursive helper function that searched through the traits supertrait hierarchy to find the associated item.
Fixes #151511