Region inference: split results from RegionInferenceContext #151688
+348
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures all of region inference is immutable, and makes every operation that requires region inference to have been executed to run explicitly require the results.
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
amandasystems
force-pushed
the
split-region-inference
branch
from
6befd69 to
13a57f6
Compare
This comment has been minimized.
This comment has been minimized.
amandasystems
force-pushed
the
split-region-inference
branch
from
13a57f6 to
00e8121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures all of region inference is immutable, and makes every operation that requires region inference to have been executed to run explicitly require the results.
I have chosen to newtype the results and lightly abstract it from outside viewers, since it's required by some consumers of the compiler internal APIs. Those should be able to find what they need to exercise the features they used to need.
r? @lcnr