Skip to content

Omit standard copyright notice #151702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xtqqczze wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Omit standard copyright notice #151702

xtqqczze wants to merge 1 commit into from
+2 −15

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jan 26, 2026

Remove copyright notices for files licensed under the standard terms (MIT OR Apache-2.0).

@xtqqczze
Omit standard copyright notice
abcd22d 
Remove copyright notices for files licensed under the standard terms (MIT OR Apache-2.0).
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu
jieyouxu previously requested changes Jan 27, 2026
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to take this PR because it modifies SPDX licenses in subtrees.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jieyouxu jieyouxu closed this Jan 27, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 27, 2026
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jan 27, 2026

Not going to take this PR because it modifies SPDX licenses in subtrees.

@jieyouxu please reopen as draft and I will remove src/doc/rustc-dev-guide/src/conventions.md from rust-lang/rustc-dev-guide repo.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 27, 2026

Please leave these licenses notices as-is.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jan 27, 2026

@jieyouxu Are you saying you don't want to take any of the changes?

rust/src/doc/rustc-dev-guide/src/conventions.md

Lines 82 to 83 in b3cda16

All of the copyright notices should be gone by now, but if you come across one
in the rust-lang/rust repo, feel free to open a PR to remove it.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 27, 2026

Are you saying you don't want to take any of the changes?

Yes, none of these specific changes, to files in subtrees.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jan 27, 2026

Are you saying you don't want to take any of the changes?

Yes, none of these specific changes, to files in subtrees.

Yes I see, so that would exclude src/doc/rustc-dev-guide and src/tools/miri

@xtqqczze xtqqczze mentioned this pull request Jan 27, 2026
Closed
@saethlin
Copy link
Member

saethlin commented Jan 27, 2026

@jieyouxu Why are you objecting to the change to the Miri subtree?

@jieyouxu
Copy link
Member

jieyouxu commented Jan 27, 2026

Why are you objecting to the change to the Miri subtree?

Hm, for whatever reason I thought miri was the subtree that had a different setup, but that wasn't it. Sorry. miri subtree shares the same licensing setup.

@jieyouxu jieyouxu reopened this Jan 27, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2026
@jieyouxu jieyouxu dismissed their stale review January 27, 2026 05:50

(mistaken)

@jieyouxu
Copy link
Member

jieyouxu commented Jan 27, 2026

Thanks, in that case we'll merge these together.
r? me @bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

📌 Commit abcd22d has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 27, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 27, 2026
@Zalathar
Rollup merge of rust-lang#151702 - xtqqczze:omit-copyright-notice, r=…
6ec16a4 
…jieyouxu

Omit standard copyright notice

Remove copyright notices for files licensed under the standard terms (MIT OR Apache-2.0).
@Zalathar Zalathar mentioned this pull request Jan 27, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151727 - Zalathar:rollup-goIJldt, r=Zalathar
78df2f9 
Rollup of 5 pull requests

Successful merges:

 - #151692 (Try to reduce rustdoc GUI tests flakyness)
 - #147436 (slice/ascii: Optimize `eq_ignore_ascii_case` with auto-vectorization)
 - #151390 (Reintroduce `QueryStackFrame` split.)
 - #151097 (Use an associated type default for `Key::Cache`.)
 - #151702 (Omit standard copyright notice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@jieyouxu jieyouxu

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @rustbot @jieyouxu @saethlin @jdonszelmann