Port rustc_abi to the attribute parser#152184
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 6, 2026
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
|
Member
|
"the entire crate?" |
Contributor
|
r? me |
jdonszelmann
reviewed
Feb 5, 2026
| continue; | ||
| }; | ||
| match tcx.def_kind(id) { | ||
| DefKind::Fn | DefKind::AssocFn => { |
Contributor
There was a problem hiding this comment.
Hmm does this match the attribute targets list? I guess it might if defkind fn also implies foreign functions.
Contributor
Author
There was a problem hiding this comment.
There are some tests of the attr with foreign functions too so I think they should match e.g. tests/ui/abi/c-zst.rs
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
9 tasks
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 5, 2026
Port rustc_abi to the attribute parser Tracking issue: rust-lang#131229 This attribute either dumps the abi info for functions (debug arg) or if you put it on a pair of fn ptr's it checks they match (assert_eq arg) r? @JonathanBrouwer
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152174 (stdarch subtree update) - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152184 (Port rustc_abi to the attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152174 (stdarch subtree update) - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152184 (Port rustc_abi to the attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152174 (stdarch subtree update) - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152184 (Port rustc_abi to the attribute parser)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 6, 2026
Port rustc_abi to the attribute parser Tracking issue: rust-lang#131229 This attribute either dumps the abi info for functions (debug arg) or if you put it on a pair of fn ptr's it checks they match (assert_eq arg) r? @JonathanBrouwer
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 6, 2026
Port rustc_abi to the attribute parser Tracking issue: rust-lang#131229 This attribute either dumps the abi info for functions (debug arg) or if you put it on a pair of fn ptr's it checks they match (assert_eq arg) r? @JonathanBrouwer
This was referenced Feb 6, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…uwer Rollup of 13 pull requests Successful merges: - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152140 (Hard code the error code registry for custom drivers) - #152155 (Fix typos in riscv64a23-unknown-linux-gnu.md) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152182 (update compiler stable backport zulip msg) - #152184 (Port rustc_abi to the attribute parser) - #152195 (update openmp/offload builds to LLVM 22, Part 1) - #152202 (chore: clearify tidy's error message) Failed merges: - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152212 (Port some attributes to the attr parser)
rust-timer
added a commit
that referenced
this pull request
Feb 6, 2026
Rollup merge of #152184 - Ozzy1423:attrs3, r=jdonszelmann Port rustc_abi to the attribute parser Tracking issue: #131229 This attribute either dumps the abi info for functions (debug arg) or if you put it on a pair of fn ptr's it checks they match (assert_eq arg) r? @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #131229
This attribute either dumps the abi info for functions (debug arg)
or if you put it on a pair of fn ptr's it checks they match (assert_eq arg)
r? @JonathanBrouwer