Store query modifier eval_always in compile-time QueryFlags#152435
Store query modifier eval_always in compile-time QueryFlags#152435Zalathar wants to merge 1 commit intorust-lang:mainfrom
eval_always in compile-time QueryFlags#152435Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Store query modifier `eval_always` in compile-time `QueryFlags`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (a6073a8): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 477.06s -> 478.55s (0.31%) |
|
This turns out to not be a clear win for either perf or bootstrap-time. It's arguably a clarity improvement, but I think I'll leave this alone for now. |
This should be a perf win, but I don't know what effect it will have on bootstrap times.