c-variadic: implement va_arg for wasm64#152594
Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
Open
c-variadic: implement va_arg for wasm64#152594folkertdev wants to merge 1 commit intorust-lang:mainfrom
va_arg for wasm64#152594folkertdev wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-LLVM
Collaborator
|
|
Member
|
@bors: r+ Thanks again for pushing on this! Agreed this looks reasonable given Derek's comment |
Contributor
|
Unknown command ":". Run |
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #44930
A LLVM maintainer of the wasm backend confirmed that the behavior on wasm64 is intented: the slot size is 4 on both wasm32 and wasm64. llvm/llvm-project#173580 (comment)
r? workingjubilee
cc @alexcrichton as target maintainer