Skip to content

fix spurious test failure in metadata_access_times #153871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Apr 12, 2026
Merged

fix spurious test failure in metadata_access_times #153871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion library/std/src/fs/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,6 +1731,8 @@ fn create_dir_all_with_junctions() {

#[test]
fn metadata_access_times() {
let start_time = SystemTime::now();

let tmpdir = tmpdir();

let b = tmpdir.join("b");
Expand All @@ -1751,7 +1753,14 @@ fn metadata_access_times() {
if cfg!(target_os = "linux") {
// Not always available
match (a.created(), b.created()) {
(Ok(t1), Ok(t2)) => assert!(t1 <= t2),
// It could be that, when the system clock goes backwards (e.g., due time change)
// b, that gets created after a, has a greater creation date than a.
// When such rare case occurs we skip the test, since the test to check that b
// should be created after a would fail.
(Ok(t1), Ok(t2)) => match start_time.elapsed() {
Ok(_) => assert!(t1 <= t2),
Err(_) => {}
},
(Err(e1), Err(e2))
if e1.kind() == ErrorKind::Uncategorized
&& e2.kind() == ErrorKind::Uncategorized
Expand Down
Loading