Skip to content

Give two tests/ui/issues/issue-*.rs tests proper names and move to more appropriate directories #154290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aryannrd wants to merge 5 commits into from
Closed

Give two tests/ui/issues/issue-*.rs tests proper names and move to more appropriate directories #154290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7d55ea
Move issue-50411 to tests/ui/mir/inliner-double-elaborate
aryannrd Mar 22, 2026
daa9ab9
Addded the link for the issue to inliner-double-elaborate.rs
aryannrd Mar 23, 2026
d98d05f
Fix tidy issues
aryannrd Mar 23, 2026
e7d2951
Moved and renamed tests/issues/issue-49973.rs to tests/enum/enum_i32_…
aryannrd Mar 24, 2026
bf2179e
Added description and link to original issue
aryannrd Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/ui/issues/issue-49973.rs → tests/ui/enum/enum_i32_min_roundtrip.rs
View file
Open in desktop
Copy link
Copy Markdown
Member

@fmease fmease Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've already performed this change in the merged PR #154615 (see file tests/ui/layout/opt-repr-i32-min.rs).

Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
//@ run-pass
//Tests enum with full i-32 range discriminants roundtrip correctly through option and casting.
//https://github.com/rust-lang/rust/issues/49973
#[derive(Debug)]
#[repr(i32)]
enum E {
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/issues/issue-50411.rs → ...r/inliner-double-elaborate-issue-50411.rs
View file
Open in desktop
Copy link
Copy Markdown
Member

@fmease fmease Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've already performed this change in the merged PR #154230 (tests/ui/mir/inliner-double-elaborate.rs).

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Regression test for #50411: the MIR inliner was causing problems
// Regression test for https://github.com/rust-lang/rust/issues/50411: the MIR inliner was causing problems
// here because it would inline promoted code (which had already had
// elaborate-drops invoked on it) and then try to elaboate drops a
// second time. Uncool.
Expand Down
Loading