rustc_feature: Separate "renamed" features from "removed" features#155129
Open
nik-rev wants to merge 2 commits intorust-lang:mainfrom
Open
rustc_feature: Separate "renamed" features from "removed" features#155129nik-rev wants to merge 2 commits intorust-lang:mainfrom
rustc_feature: Separate "renamed" features from "removed" features#155129nik-rev wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-tidy
Collaborator
|
rustbot has assigned @jdonszelmann. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
nik-rev
force-pushed
the
renamed-features
branch
from
07786ce to
f970aca
Compare
This comment has been minimized.
This comment has been minimized.
nik-rev
force-pushed
the
renamed-features
branch
from
f970aca to
465bdd7
Compare
This comment has been minimized.
This comment has been minimized.
nik-rev
force-pushed
the
renamed-features
branch
from
465bdd7 to
47f4436
Compare
This comment has been minimized.
This comment has been minimized.
nik-rev
force-pushed
the
renamed-features
branch
from
47f4436 to
664fbe8
Compare
This comment has been minimized.
This comment has been minimized.
nik-rev
force-pushed
the
renamed-features
branch
2 times, most recently
from
abdc8a8 to
0c0cf8f
Compare
nik-rev
force-pushed
the
renamed-features
branch
from
0c0cf8f to
1876340
Compare
Kivooeo
reviewed
Apr 18, 2026
| code = "{new_name}", | ||
| applicability = "machine-applicable" | ||
| )] | ||
| #[label("feature was renamed")] |
Member
There was a problem hiding this comment.
this label duplicates a message from diag
Contributor
Author
There was a problem hiding this comment.
old diagnostic had the same label and diagnostic message, so I just mirrored that:
- error[E0557]: feature has been removed
+ error[E0557]: feature was renamed
--> $DIR/feature-gate-sanitize.rs:1:12
|
LL | #![feature(no_sanitize)]
- | ^^^^^^^^^^^ feature has been removed
+ | ^^^^^^^^^^^
+ | |
+ | feature was renamed
+ | help: update to the new name: `sanitize`
Member
There was a problem hiding this comment.
yeah, let's drop it from both in a follow up, or remvoe it from renamed now and from removed in a follow up, smth like this
Member
There was a problem hiding this comment.
(this review not for this test specific, but i need to put it somewhere, so just random file)
we need to add a //@ run-rustfix test, to check that machine-applicable fix works when applied
| /// Allows `#[no_coverage]` on functions. | ||
| /// The feature was renamed to `coverage_attribute` and the attribute to `#[coverage(on|off)]` | ||
| (renamed, no_coverage => coverage_attribute, "1.74.0", Some(84605), 114656), | ||
| // Allows the use of `no_sanitize` attribute. |
Co-authored-by: Kivooeo <75776246+Kivooeo@users.noreply.github.com>
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are quite a few "renamed" features that are grouped in the same category as "removed".
So I've split them up into a separate
renamed.rsfile, and added a new category for "Renamed" features.This has the following advantages:
tidyscript is updated to check that the new feature names actually exist.