BorrowedBuf: Update outdated safety comments in set_init users.#155314
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 15, 2026
Merged
BorrowedBuf: Update outdated safety comments in set_init users.#155314rust-bors[bot] merged 1 commit intorust-lang:mainfrom
BorrowedBuf: Update outdated safety comments in set_init users.#155314rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
These comments appear to have been written before `BorrowedBuf`'s init tracking was simplified in rust-lang#150129. The `BufWriter` comment of the usage within `BufWriter` will be handled separately.
Member
|
This looks good to me, and seems like an improvement. r=me when CI passed. (It's just comments, so I don't expect CI to have anything to say, but I have the habit these days of not just r+ing something even if I think it couldn't possibly fail CI.) |
Member
|
@bors d+ |
Contributor
|
Unknown command "d+". Run |
Member
|
@bors delegate+ |
Contributor
|
✌️ @briansmith, you can now approve this pull request! If @joshtriplett told you to " |
Contributor
Author
|
@bors r=joshtriplett |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Rollup of 13 pull requests Successful merges: - #154882 (Gate tuple const params behind `min_adt_const_params` feature) - #155259 (explicit-tail-calls: disable two tests on LoongArch) - #155293 (fix arch names in cfg pretty printer) - #155314 (`BorrowedBuf`: Update outdated safety comments in `set_init` users.) - #153469 (docs: clarify path search behavior in std::process::Command::new) - #154765 (Clarify ascii whitespace exclusion of vertical tab in the doc) - #155172 (Some small nits for supertrait_item_shadowing, and additional testing) - #155279 (Test/lexer unicode pattern white space) - #155280 (Tests for precise-capture through RPIT and TAIT) - #155301 (Delete unused `rustc_trait_selection` errors.) - #155303 (remove ibraheemdev from review rotation) - #155304 (remove PointeeParser) - #155319 (Remove dead diagnostic structs.)
rust-timer
added a commit
that referenced
this pull request
Apr 15, 2026
Rollup merge of #155314 - briansmith:b/comments, r=joshtriplett `BorrowedBuf`: Update outdated safety comments in `set_init` users. These comments appear to have been written before `BorrowedBuf`'s init tracking was simplified in #150129. The `BufWriter` comment of the usage within `BufWriter` will be handled separately. CC #78485, #117693.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 2, 2026
…pratt `bufreader::Buffer`: Remove leftover note about `initialized` field Just a boring little doc fix! : v) rust-lang#150129 reworked the `initialized` field to be a `bool` instead of a `usize`. And then rust-lang#155314 reworked this field's comment (among other things). But, there's still a leftover note in the comment, which no longer makes sense: ``Note that while this often the same as `filled`, it doesn't need to be.`` This is referencing that back when `initialized` was a `usize`, it was common for it to have the same value as `filled`. ---- Fun fact: there's a typo in the note too! It's missing an "is" before or after "often".
rust-timer
added a commit
that referenced
this pull request
May 2, 2026
Rollup merge of #156026 - InsertCreativityHere:patch-1, r=jhpratt `bufreader::Buffer`: Remove leftover note about `initialized` field Just a boring little doc fix! : v) #150129 reworked the `initialized` field to be a `bool` instead of a `usize`. And then #155314 reworked this field's comment (among other things). But, there's still a leftover note in the comment, which no longer makes sense: ``Note that while this often the same as `filled`, it doesn't need to be.`` This is referencing that back when `initialized` was a `usize`, it was common for it to have the same value as `filled`. ---- Fun fact: there's a typo in the note too! It's missing an "is" before or after "often".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These comments appear to have been written before
BorrowedBuf's init tracking was simplified in#150129. The
BufWritercomment of the usage withinBufWriterwill be handled separately.CC #78485, #117693.