Skip to content

docs: Fix typo in std/src/thready/scoped.rs#155454

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
MadeInShineA:issue-155275-fix
Apr 18, 2026
Merged

docs: Fix typo in std/src/thready/scoped.rs#155454
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
MadeInShineA:issue-155275-fix

Conversation

@MadeInShineA
Copy link
Copy Markdown
Contributor

@MadeInShineA MadeInShineA commented Apr 17, 2026 •
edited
Loading

Fix typo in std/src/thread/scoped.rs

Why this pr

This PR closes #155275 fixing the mentioned typo.

I know this was originally fixed in #155325 and then in #155328.

But since the first issue was closed due to some ai slop and the second one was closed because the first one was already opened, it seems to me that this PR is still needed.

What this pr does

This PR "just" fixes a typo inside the std/src/thread/scoped.rs file

Changing the comment from this:

/// borrow non-`'static` data from the outside the scope. See [`scope`] for
/// details.

to this:

/// borrow non-`'static` data from outside the scope. See [`scope`] for
/// details.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 17, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt

@lqd
Copy link
Copy Markdown
Member

lqd commented Apr 17, 2026

Thanks!

r? me @bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 17, 2026

📌 Commit 10cc6c4 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 18, 2026
@jhpratt
Rollup merge of rust-lang#155454 - MadeInShineA:issue-155275-fix, r=lqd
c81cf9a 
docs: Fix typo in std/src/thready/scoped.rs

# Fix typo in std/src/thread/scoped.rs

## Why this pr

This PR fixes the typo mentioned in rust-lang#155275.

I know this was originally fixed in rust-lang#155325 and then in rust-lang#155328.

But since the first issue was closed due to some ai slop and the second one was closed because the first one was already opened, it seems to me that this PR is still needed.

## What this pr does

This PR "just" fixes a typo inside the `std/src/thread/scoped.rs` file

Changing the comment from this:

```
/// borrow non-`'static` data from the outside the scope. See [`scope`] for
/// details.
```

to this:

```
/// borrow non-`'static` data from outside the scope. See [`scope`] for
/// details.
```
This was referenced Apr 18, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 18, 2026
@bors
Auto merge of #155472 - jhpratt:rollup-cFOYOWJ, r=jhpratt
7a38981 
Rollup of 12 pull requests

Successful merges:

 - #147811 (naked functions: respect `function-sections`)
 - #154935 (Add Sized supertrait for CoerceUnsized and DispatchFromDyn)
 - #139690 (`impl Default for RepeatN`)
 - #153511 (`std::any::TypeId`: remove misplaced "and" in `Unique<T>` example)
 - #154943 (Move recursion out of `MatchPairTree::for_pattern` helpers )
 - #155295 (Fix misleading "borrowed data escapes outside of function" diagnostic)
 - #155427 (ptr: update text in intro text to one in with_addr doc)
 - #155428 (Fix ICE in borrowck mutability suggestion with multi-byte ref sigil)
 - #155435 (rustdoc: Fix `redundant_explicit_links` incorrectly firing (or not firing) under certain scenarios)
 - #155450 (Remove unnecessary safety conditions related to unchecked uint arithmetic)
 - #155454 (docs: Fix typo in std/src/thready/scoped.rs)
 - #155467 (`std::error::Request`: clean up documentation)
@reddevilmidzy
Copy link
Copy Markdown
Member

reddevilmidzy commented Apr 18, 2026

@MadeInShineA Please refrain from using LLM when writing PR descriptions.

@MadeInShineA
Copy link
Copy Markdown
Contributor Author

MadeInShineA commented Apr 18, 2026 •
edited
Loading

@MadeInShineA Please refrain from using LLM when writing PR descriptions.

I didn't use an llm to write the description...

@reddevilmidzy
Copy link
Copy Markdown
Member

reddevilmidzy commented Apr 18, 2026

@MadeInShineA Please refrain from using LLM when writing PR descriptions.

I didn't use an llm to write the description...

I see that I misunderstood—my apologies. for minor typo fixes like this, it might be better to keep the PR description more concise.
Additionally, if you add closes #155275 to the PR description, the issue will be automatically closed when the PR is merged.

@MadeInShineA
Copy link
Copy Markdown
Contributor Author

MadeInShineA commented Apr 18, 2026

@MadeInShineA Please refrain from using LLM when writing PR descriptions.

I didn't use an llm to write the description...

I see that I misunderstood—my apologies. for minor typo fixes like this, it might be better to keep the PR description more concise.
Additionally, if you add closes #155275 to the PR description, the issue will be automatically closed when the PR is merged.

Thanks for your feedback! Is the closes #155275 something configured on this repo or is it a Github thing ?

Also should I edit the description to add it then ?

@reddevilmidzy
Copy link
Copy Markdown
Member

reddevilmidzy commented Apr 18, 2026

Yes, it’s a GitHub feature, and it’s enabled in the rust-lang/rust repo as well.

cc: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Also should I edit the description to add it then ?

Yes, please add that line to the description.

@MadeInShineA
Copy link
Copy Markdown
Contributor Author

MadeInShineA commented Apr 18, 2026 •
edited
Loading

Yes, it’s a GitHub feature, and it’s enabled in the rust-lang/rust repo as well.

cc: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Also should I edit the description to add it then ?

Yes, please add that line to the description.

Thanks! I have modified the description (I'm on mobile so I'm not sure it worked)

I will look into this feature!

@rust-bors rust-bors Bot merged commit 4fa293c into rust-lang:main Apr 18, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 18, 2026
rust-timer added a commit that referenced this pull request Apr 18, 2026
@rust-timer
Unrolled build for #155454
778f1f7 
Rollup merge of #155454 - MadeInShineA:issue-155275-fix, r=lqd

docs: Fix typo in std/src/thready/scoped.rs

# Fix typo in std/src/thread/scoped.rs

## Why this pr

This PR fixes the typo mentioned in #155275.

I know this was originally fixed in #155325 and then in #155328.

But since the first issue was closed due to some ai slop and the second one was closed because the first one was already opened, it seems to me that this PR is still needed.

## What this pr does

This PR "just" fixes a typo inside the `std/src/thread/scoped.rs` file

Changing the comment from this:

```
/// borrow non-`'static` data from the outside the scope. See [`scope`] for
/// details.
```

to this:

```
/// borrow non-`'static` data from outside the scope. See [`scope`] for
/// details.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

Typo on where a scoped thread can borrow from

5 participants

@MadeInShineA @rustbot @lqd @reddevilmidzy @Mark-Simulacrum