Tweak is_ascii_punctuation() docs wording#155531
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 20, 2026
Merged
Tweak is_ascii_punctuation() docs wording#155531rust-bors[bot] merged 1 commit intorust-lang:mainfrom
is_ascii_punctuation() docs wording#155531rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @scottmcm rustbot has assigned @scottmcm. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
the
A-docs
Member
|
TBH, this doesn't read any better to me -- I'd still have to depend on vibes to know what it's doing. Maybe it'd be better as a separate paragraph talking about specifically what it means by "punctuation", even if that's a historical term that doesn't match exactly to unicode's categories? @rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
The `_punctuation` methods return `true` for characters with Unicode general category of punctuation (P), but also for those with general category of symbol (S).
Jules-Bertholet
force-pushed
the
is_ascii_punctuation_docs
branch
from
fcc64b9 to
fd65209
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
Sure, I guess? @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…uwer Rollup of 10 pull requests Successful merges: - #155054 (constify `Index(Mut)`, `Deref(Mut)` for `Vec`) - #155264 (Add autocast support for `x86amx`) - #155507 (suggest expect instead of unwrap when arg provided) - #154664 (core/num: Implement feature `integer_cast_extras`) - #155238 (compiletest: add a new diff for compare-out-by-lines tests.) - #155474 (Rename incremental `cfail`/`cpass` revisions to `bfail`/`bpass`) - #155493 (docs(num): fix stale link to `mem::Alignment`) - #155529 (Remove `AttributeLintKind` variants - part 3) - #155531 (Tweak `is_ascii_punctuation()` docs wording) - #155533 (Provide a const new for `GlobalCache`)
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 20, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#155054 (constify `Index(Mut)`, `Deref(Mut)` for `Vec`) - rust-lang/rust#155264 (Add autocast support for `x86amx`) - rust-lang/rust#155507 (suggest expect instead of unwrap when arg provided) - rust-lang/rust#154664 (core/num: Implement feature `integer_cast_extras`) - rust-lang/rust#155238 (compiletest: add a new diff for compare-out-by-lines tests.) - rust-lang/rust#155474 (Rename incremental `cfail`/`cpass` revisions to `bfail`/`bpass`) - rust-lang/rust#155493 (docs(num): fix stale link to `mem::Alignment`) - rust-lang/rust#155529 (Remove `AttributeLintKind` variants - part 3) - rust-lang/rust#155531 (Tweak `is_ascii_punctuation()` docs wording) - rust-lang/rust#155533 (Provide a const new for `GlobalCache`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods return
truefor characters with Unicode general category of punctuation (P), but also for those with general category of symbol (S).@rustbot label A-docs