Fix redundant boolean comparison in Mutex::try_lock#155532
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 21, 2026
Merged
Fix redundant boolean comparison in Mutex::try_lock#155532rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Mutex::try_lock#155532rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
Rollup of 5 pull requests Successful merges: - #155532 (Fix redundant boolean comparison in `Mutex::try_lock`) - #155558 (Clarify that isqrt returns the principal (non-negative) square root) - #155559 (add safety doc (section header) to two unsafe methods in `NonZero`) - #155564 (Implement const Default for &CStr) - #155565 (constify `Vec` comparisons)
rust-timer
added a commit
that referenced
this pull request
Apr 21, 2026
Rollup merge of #155532 - StepfenShawn:patch-1, r=jhpratt Fix redundant boolean comparison in `Mutex::try_lock` Simplify boolean return in `Mutex::try_lock`. Replace `expr == false` with `!expr` for cleaner code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify boolean return in
Mutex::try_lock.Replace
expr == falsewith!exprfor cleaner code.