-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing ConstParamTy
#155675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rust-bors
merged 1 commit into
rust-lang:main
from
zedddie:disallow-non_exhaustive-adt-const-params
Apr 28, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
tests/ui/const-generics/min_adt_const_params/forbid-non_exhaustive-const-param-ty.min.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| error: the trait `ConstParamTy` may not be implemented for this type | ||
| --> $DIR/forbid-non_exhaustive-const-param-ty.rs:13:12 | ||
| | | ||
| LL | #[non_exhaustive] | ||
| | ----------------- caused by this attribute | ||
| LL | #[derive(PartialEq, Eq, ConstParamTy)] | ||
| | ------------ in this derive macro expansion | ||
| LL | pub struct Miow; | ||
| | ^^^^ non exhaustive const params are forbidden | ||
|
|
||
| error: the trait `ConstParamTy` may not be implemented for this type | ||
| --> $DIR/forbid-non_exhaustive-const-param-ty.rs:17:10 | ||
| | | ||
| LL | #[derive(PartialEq, Eq, ConstParamTy)] | ||
| | ------------ in this derive macro expansion | ||
| LL | pub enum Enumiow { | ||
| | ^^^^^^^ non exhaustive const params are forbidden | ||
| LL | | ||
| LL | #[non_exhaustive] NonExhaustiveThingie, | ||
| | ----------------- caused by this attribute | ||
|
|
||
| error: aborting due to 2 previous errors | ||
|
|
30 changes: 30 additions & 0 deletions
30
tests/ui/const-generics/min_adt_const_params/forbid-non_exhaustive-const-param-ty.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| //! Ensure that non exhaustive structs and enums with non exhaustive variants | ||
| //! aren't allowed to implement ConstParamTy under min_adt_const_params feature | ||
| //@ revisions: full min | ||
| //@[full] check-pass | ||
| #![cfg_attr(min, feature(min_adt_const_params))] | ||
| #![cfg_attr(full, feature(adt_const_params))] | ||
| #![allow(incomplete_features)] | ||
|
|
||
| use std::marker::ConstParamTy; | ||
|
|
||
| #[non_exhaustive] | ||
| #[derive(PartialEq, Eq, ConstParamTy)] | ||
| pub struct Miow; | ||
| //[min]~^ ERROR: the trait `ConstParamTy` may not be implemented for this type | ||
|
|
||
| #[derive(PartialEq, Eq, ConstParamTy)] | ||
| pub enum Enumiow { | ||
| //[min]~^ ERROR: the trait `ConstParamTy` may not be implemented for this type | ||
| #[non_exhaustive] NonExhaustiveThingie, | ||
| ExhaustiveThingie, | ||
| } | ||
|
|
||
| #[non_exhaustive] | ||
| #[derive(PartialEq, Eq, ConstParamTy)] | ||
| pub enum EnumiowButFine { | ||
| ExhaustiveThingie, | ||
| AlsoExhaustiveThingie, | ||
| } | ||
|
|
||
| fn main() {} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure now, should it go into const-generics/adt_const_params or its fine as it is in min 🧐
View changes since the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min is ok :3