Pass fields to is_tuple_fields instead of SBValue object#155738
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 25, 2026
Merged
Pass fields to is_tuple_fields instead of SBValue object#155738rust-bors[bot] merged 1 commit intorust-lang:mainfrom
is_tuple_fields instead of SBValue object#155738rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
approved these changes
Apr 25, 2026
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 25, 2026
Rollup of 7 pull requests Successful merges: - #155643 (Improve suggestion for $-prefixed fragment specifiers) - #154197 (Avoid redundant clone suggestions in borrowck diagnostics) - #154372 (Exposing Float Masks) - #155680 (Handle index projections in call destinations in DSE) - #155732 (bootstrap: Don't clone submodules unconditionally in dry-run) - #155737 (Account for `GetSyntheticValue` failures) - #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
rust-timer
added a commit
that referenced
this pull request
Apr 25, 2026
Rollup merge of #155738 - Walnut356:tuple_fields, r=jieyouxu Pass fields to `is_tuple_fields` instead of `SBValue` object straightforward fix for a logic error. `is_tuple_fields` expects a `list`, so we pass that in instead of the value object. Coincidentally, this also fixes one of the 3 DI tests that fails on `x86_64-pc-windows-gnu` (`tests/debuginfo/union-smoke.rs`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
straightforward fix for a logic error.
is_tuple_fieldsexpects alist, so we pass that in instead of the value object.Coincidentally, this also fixes one of the 3 DI tests that fails on
x86_64-pc-windows-gnu(tests/debuginfo/union-smoke.rs)