Skip to content

Render ConstContext for diagnostics once#155866

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
oli-obk:push-xunxtyqlvwpk
Apr 27, 2026
Merged

Render ConstContext for diagnostics once#155866
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
oli-obk:push-xunxtyqlvwpk

Conversation

@oli-obk
Copy link
Copy Markdown
Contributor

@oli-obk oli-obk commented Apr 27, 2026

Probably just a left-over from the ftl file removal

instead of duplicating in every diagnostic
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 27, 2026

Some changes occurred to the CTFE machinery

cc @RalfJung, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 27, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@RalfJung
Copy link
Copy Markdown
Member

r=me with green CI

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 27, 2026

@bors r=RalfJung

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 27, 2026

📌 Commit 44617ef has been approved by RalfJung

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2026
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 27, 2026

@bors rollup

@lcnr lcnr assigned RalfJung and unassigned petrochenkov Apr 27, 2026
rust-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154465 (triagebot: Mention 'subtree' in clippy message)
 - #155355 (Fix pathological performance in trait solver cycles with errors)
 - #155716 (arm64e: set ptrauth ABI subtype on lib.rmeta Mach-O objects)
 - #155864 (Fix panic for doc attributes on where predicates)
 - #155865 (add test for accidentally fixed `binius_field` issue)
 - #155866 (Render `ConstContext` for diagnostics once)
@rust-bors rust-bors Bot merged commit ff66507 into rust-lang:main Apr 27, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Apr 27, 2026
Rollup merge of #155866 - oli-obk:push-xunxtyqlvwpk, r=RalfJung

Render `ConstContext` for diagnostics once

Probably just a left-over from the `ftl` file removal
@rustbot rustbot added this to the 1.97.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants