turn compute_goal_fast_path into a single match#156038
Merged
rust-bors[bot] merged 1 commit intoMay 8, 2026
Merged
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
fast-path-single-match
branch
from
251df8d to
405d223
Compare
lcnr
reviewed
May 6, 2026
lcnr
reviewed
May 6, 2026
lcnr
reviewed
May 6, 2026
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri changes to the core type system cc @lcnr Some changes occurred to the CTFE machinery |
rustbot
added
S-waiting-on-review
jdonszelmann
force-pushed
the
fast-path-single-match
branch
from
405d223 to
2bb7e69
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
May 7, 2026
jdonszelmann
force-pushed
the
fast-path-single-match
branch
from
2bb7e69 to
0e10c8a
Compare
jdonszelmann
force-pushed
the
fast-path-single-match
branch
from
0e10c8a to
644250d
Compare
Contributor
Author
|
@bors r=lcnr rollup |
Contributor
|
📋 This PR cannot be approved because it currently has the following label: |
jdonszelmann
removed
the
S-blocked
Contributor
Author
|
@bors r=lcnr rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
May 8, 2026
…uwer Rollup of 4 pull requests Successful merges: - #156246 (Introduce a `RerunNonErased` error type mirroring `NoSolution`, to better track when we're bailing) - #156038 (turn `compute_goal_fast_path` into a single match) - #156291 (Treat MSVC "performing full link" message as informational) - #156301 (Avoid ICE when suggesting as_ref for ill-typed closure receivers)
rust-timer
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @lcnr
@rustbot blocked on #155443