[WIP] MIR move elimination pass#156046
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 884fdb2 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
|
💔 Test for b42852b failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
This is no longer true as of rust-lang#107267.
- Changed `iter_intervals` to return `RangeInclusive` instead of `Range` - Added `clear_row`, `disjoint_rows` and `append_range` methods
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
|
💔 Test for 8165e10 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (6c8a539): comparison URL. Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILEDBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never ❗ ❗ ❗ ❗ ❗
❗ ❗ ❗ ❗ ❗ Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 6.2%, secondary 20.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 18.5%, secondary 1818.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 5.0%, secondary 2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 495.343s -> 534.143s (7.83%) |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (7de3958): comparison URL. Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILEDBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never ❗ ❗ ❗ ❗ ❗
❗ ❗ ❗ ❗ ❗ Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.8%, secondary 1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.6%, secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 1.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 495.891s -> 480.313s (-3.14%) |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (bc25cfa): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 6.8%, secondary 25.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 24.4%, secondary 1817.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 4.8%, secondary 2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 497.794s -> 533.437s (7.16%) |
View all comments
This is very much a work in progress, and will sometimes generate broken/unsound MIR.