Skip to content

[AIX] add -bdbg:namedsects:ss link arg#156159

Open
daltenty wants to merge 1 commit intorust-lang:mainfrom
daltenty:daltenty/namesects
Open

[AIX] add -bdbg:namedsects:ss link arg#156159
daltenty wants to merge 1 commit intorust-lang:mainfrom
daltenty:daltenty/namesects

Conversation

@daltenty
Copy link
Copy Markdown
Contributor

@daltenty daltenty commented May 4, 2026

On AIX, the PGO runtime and ifunc runtime support requires the named section linker feature which collects the name sections together and generates start/stop symbols for them.

This change adds the option to the default linker args for the target.

On AIX, PGO runtimes and ifunc support requires the named section linker feature which collects the name sections together and generates start/stop symbols for them.

This change adds the option to the default linker args for the target.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 4, 2026

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 4, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 4, 2026

r? @tiif

rustbot has assigned @tiif.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 21 candidates

@workingjubilee
Copy link
Copy Markdown
Member

workingjubilee commented May 5, 2026

I see no significant reason to not simply r+ this aside from "is there any meaningful negative effect on linked executables and libraries when you're not doing PGO?"

This is just a small per-section binary size overhead, right?

And ifuncs? Defining new ifuncs, calling them, or both?

Happy to sign off on it either way if I understand correctly, just want to make sure I actually do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants