[AIX] add -bdbg:namedsects:ss link arg#156159
Open
daltenty wants to merge 1 commit intorust-lang:mainfrom
Open
[AIX] add -bdbg:namedsects:ss link arg#156159daltenty wants to merge 1 commit intorust-lang:mainfrom
daltenty wants to merge 1 commit intorust-lang:mainfrom
Conversation
On AIX, PGO runtimes and ifunc support requires the named section linker feature which collects the name sections together and generates start/stop symbols for them. This change adds the option to the default linker args for the target.
Collaborator
|
These commits modify compiler targets. |
Collaborator
|
r? @tiif rustbot has assigned @tiif. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
I see no significant reason to not simply r+ this aside from "is there any meaningful negative effect on linked executables and libraries when you're not doing PGO?" This is just a small per-section binary size overhead, right? And ifuncs? Defining new ifuncs, calling them, or both? Happy to sign off on it either way if I understand correctly, just want to make sure I actually do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On AIX, the PGO runtime and ifunc runtime support requires the named section linker feature which collects the name sections together and generates start/stop symbols for them.
This change adds the option to the default linker args for the target.