Skip to content

fix(clippy): std_instead_of_core false positive for core::io#156164

Open
bushrat011899 wants to merge 1 commit intorust-lang:mainfrom
bushrat011899:fix_std_instead_of_core_for_core_io
Open

fix(clippy): std_instead_of_core false positive for core::io#156164
bushrat011899 wants to merge 1 commit intorust-lang:mainfrom
bushrat011899:fix_std_instead_of_core_for_core_io

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

@bushrat011899 bushrat011899 commented May 5, 2026

Objective

Solution

Previously the lint had an exception for all instances of a stable item in an unstable module, primarily to allow certain intrinsics such as copy to be accessible. Instead, I check for the presence of rustc_allowed_through_unstable_modules to handle those exceptions, and allow the is_stable check within the lint to early out as soon as any part of its path is unstable.


Notes

  • No AI tooling of any kind was used during the creation of this PR.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 5, 2026

The Clippy subtree was changed

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels May 5, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 5, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants