Fill in example code for HashMap. #15787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thank you for docs. 😍 |
Add an example showing how to use the map with a custom type. Fill in examples for methods in the hashmap file without ones. Also move pop_equiv next to related public methods, to not create a duplicate trait implementation in the docs.
|
Rebased. |
| @@ -729,6 +729,30 @@ impl DefaultResizePolicy { | |||
| /// println!("{}: \"{}\"", *book, *review); | |||
| /// } | |||
| /// ``` | |||
| /// | |||
| /// The easiest way to use `HashMap` with a custom type is to derive `Eq` and `Hash`. | |||
| /// We must also derive `PartialEq`, but this will in the future be implied by `Eq`. | |||
There was a problem hiding this comment.
I think the forward looking " but this will ..." part of the sentence can be removed.
Link to mentioned methods. Use `# Failure` tags to describe failure. Make `pop_equiv`, `find_equiv` and `get_copy` standalone.
|
Is this ready to go? |
|
Looks good to me, thanks @treeman! Also feel free to comment on the PR whenever you force-push, sadly github doesn't send out notifications otherwise. |
bors
added a commit
that referenced
this pull request
Jul 25, 2014
Add an example showing how to use the map with a custom type. Fill in examples for methods without ones. Also move `pop_equiv` next to related public methods, to not create a duplicate trait in the docs.
|
Ah I see, will do in the future. Thanks. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
Store binding mode for each instance of a binding independently fix rust-lang#15787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example showing how to use the map with a custom type. Fill in
examples for methods without ones.
Also move
pop_equivnext to related public methods, to not create aduplicate trait in the docs.