Skip to content

Lexer tests #15867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 22, 2014
Merged

Lexer tests #15867

merged 12 commits into from
Jul 22, 2014

Conversation

emberian
Copy link
Member

No description provided.

@emberian
Copy link
Member Author

This is almost good to go, just having some problems with the makefile. It says:

cfg: including grammar tests
Running lexer verification...
/home/cmr/src/rust2/mk/grammar.mk:41: *** missing separator.  Stop.

Which confuses me because it prints the message from line 41. I've tried everything I can, and remake isn't helpful either...

alexcrichton
alexcrichton reviewed Jul 21, 2014
View reviewed changes
mk/grammar.mk

check-lexer: $(BG) $(BG)RustLexer.class $(BG)verify
$(info Verifying libsyntax against the reference lexer ...)
$(Q)$(foreach file,$(call rwildcard,$(S),*.rs),$(eval $(call LEXER_TEST,$(file))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it could expand to a lot of files! Does it take make a noticeable amount of time to include this file? An alternative would perhaps be to just pass the root directory into the tool itself and the tool manually walks all the directories.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may also be the source of the makefile weirdness you were seeing, although I'm not quite sure.

@alexcrichton
Copy link
Member

Looks good to me! Just curious about when/where these are going to be running and I think this is good to go with some squashing.

@emberian
Copy link
Member Author

@alexcrichton squashed a bit and doesn't run tests by default. r+?

bors added a commit that referenced this pull request Jul 22, 2014
@bors
auto merge of #15867 : cmr/rust/rewrite-lexer4, r=alexcrichton
8d43e44
@bors bors closed this Jul 22, 2014
@bors bors merged commit 95a1ce6 into rust-lang:master Jul 22, 2014
@pitdicker pitdicker mentioned this pull request Mar 30, 2018
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2024
@bors
Auto merge of rust-lang#15868 - wasd96040501:fix/symlink2, r=Veykril
87e609a 
fix: failed to infer OUT_DIR when workspace root contains symlink

fix rust-lang#15867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emberian @alexcrichton @bors