Skip to content

Fix assert message #15979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2014
Merged

Fix assert message #15979

merged 1 commit into from
Jul 25, 2014

Conversation

Randati
Copy link
Contributor

@Randati Randati commented Jul 25, 2014

No description provided.

@lilyball
Copy link
Contributor

As long as you're fixing this, I think it should say 2...36 instead of 2..36. The latter has a lot of precedent for meaning [2,36) instead of [2,36].

@Randati
Copy link
Contributor Author

Randati commented Jul 25, 2014

Two dots are used for inclusive range in match and in a couple comments elsewhere. Three dots are not used anywhere in rust. Wouldn't it be better to be consistent with those?

@lilyball
Copy link
Contributor

Oh it is? Guess I've never actually used the range functionality of match. I suppose remaining consistent with those is correct, though perhaps we should reevaluate that syntax.

bors added a commit that referenced this pull request Jul 25, 2014
@bors bors closed this Jul 25, 2014
@bors bors merged commit c770007 into rust-lang:master Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants