vim: Stop setting conceallevel in the syntax file #16486
Conversation
We shouldn't be setting conceallevel in the syntax file. Besides not being able to undo this if we switch to another syntax later, it also interferes with embedding rust in other filetypes (such as markdown). Instead, set it in the ftplugin, where it belongs.
|
The only change in functionality here is that the I’m ambivalent about this. At present all the conceal stuff (second-class, anyway) is in one file; this starts spreading the poison into other files (even if it’s “the right place to do it”). |
|
Actually, this was motivated by syntax embedding. When I write a markdown file it embeds rust (because I have it configured for fenced code blocks) and that was causing it to unexpectedly enable conceal in the markdown file. |
|
@kballard you mean after/syntax/rust.vim doesn’t get used with |
|
It does, that's the problem. Which is why it shouldn't be setting conceallevel, that's something the "main" syntax should be controlling. |
|
Sorry, I meant ftplugin/rust.vim. It doesn’t get used with |
|
@chris-morgan Nope. That file is only included when the |
|
LGTM. |
We shouldn't be setting conceallevel in the syntax file. Besides not being able to undo this if we switch to another syntax later, it also interferes with embedding rust in other filetypes (such as markdown). Instead, set it in the ftplugin, where it belongs.
internal: Set channel override when querying the sysroot metadata This is pretty hard to discover, and makes the setting useless, we should probably enable it for now. CC rust-lang#16486
We shouldn't be setting conceallevel in the syntax file. Besides not
being able to undo this if we switch to another syntax later, it also
interferes with embedding rust in other filetypes (such as markdown).
Instead, set it in the ftplugin, where it belongs.