Fix vector/array/slice terminology in manual. #16825
Conversation
| definite-sized vector contents into a distinct vector of indefinite size. | ||
| * `Vec<T>`, a 'vector' | ||
| * [T ..N], an 'array' | ||
| * &[T], a 'slice.' |
There was a problem hiding this comment.
Could you include arrays and slices in backticks (just for readability).
I'm not sure how much precedent we have in the manual for this, but you may want to explicitly point out that Vec<T> is not part of the language, only arrays and slices are. As a user of rust I should be aware of all three, but as a theoretical compiler implementer there's only two
There was a problem hiding this comment.
At the risk of a horrible bikeshed, shouldn't the . not be in the quotes (i.e. 'slice'.) since the quotes are essentially defining the technical term.
There was a problem hiding this comment.
I'm not sure how much precedent we have in the manual for this
I guess we need to work out if the manual is purely language manual/"specification", or if it is designed to include the libraries too.
There was a problem hiding this comment.
Yes, I agree they should be in backticks.
And yeah, it's an open question about language vs libraries. right now, it includes a lot of library stuff, so I think this still belongs here for now.
|
Thanks @steveklabnik! Out with cruft, in with the new! |
steveklabnik
force-pushed
the
fix_manual_array_terms
branch
from
24fcc5f to
3de1f2e
Compare
|
Updated! |
| An example of a vector type and its use: | ||
| A vector is a heap-allocated list of `T`. A vector has ownership over the data | ||
| inside of it. It is also able to grow and change in size. It's important to note | ||
| that `Vec<T>` is a library type, it's not actulaly part of the core language. |
|
Thanks! r=me with one typo |
steveklabnik
force-pushed
the
fix_manual_array_terms
branch
from
3de1f2e to
de82434
Compare
|
Whoops! Typo fixed. |
steveklabnik
force-pushed
the
fix_manual_array_terms
branch
from
de82434 to
a021330
Compare
|
This has been updated. r? |
fixes #16015