Add ICE regression test with unboxed closures #17093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code used to produce the following ICE:
error: internal compiler error: get_unique_type_id_of_type() -
unexpected type: closure,
ty_unboxed_closure(syntax::ast::DefId{krate: 0u32, node: 66u32},
ReScope(63u32))
This is a regression test for issue rust-lang#17021.
|
<3 tests |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 9, 2014
nathantypanski
added a commit
to nathantypanski/rust
that referenced
this pull request
Sep 12, 2014
This catches two unhandled patterns in middle/trans/debuginfo.rs where a ty::ty_unboxed_closure could show up, preventing various potential ICEs when #[feature(unboxed_closures)] is used with `-g`. It also updates the test case from rust-lang#17093 in response to new information from rust-lang#17021 showing that the test still caused an ICE when compiling with debuginfo. Closes rust-lang#17021.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…Veykril fix: VFS should not walk circular symlinks As of rust-lang#6246, rust-analyzer follows symlinks. This can introduce an infinite loop if symlinks point to parent directories. Considering that rust-lang#6246 was added in 2020 without many bug reports, this is clearly a rare occurrence. However, I am observing rust-analyzer hang on projects that have symlinks of the form: ``` test/a_symlink -> ../../ ``` Ignore symlinks that only point to the parent directories, as this is more robust but still allows typical symlink usage patterns.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…Veykril fix: VFS should not walk circular symlinks As of rust-lang#6246, rust-analyzer follows symlinks. This can introduce an infinite loop if symlinks point to parent directories. Considering that rust-lang#6246 was added in 2020 without many bug reports, this is clearly a rare occurrence. However, I am observing rust-analyzer hang on projects that have symlinks of the form: ``` test/a_symlink -> ../../ ``` Ignore symlinks that only point to the parent directories, as this is more robust but still allows typical symlink usage patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code used to produce the following ICE:
This is a regression test for issue #17021.