Rename begin_unwind lang item and core function #17428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| #[cfg(not(stage0))] | ||
| #[cold] #[inline(never)] // this is the slow path, always | ||
| #[lang="fail"] | ||
| fn fail_(expr_file_line: &(&'static str, &'static str, uint)) -> ! { |
There was a problem hiding this comment.
Could the name of this function just be fail?
|
Thanks for this! |
fhahn
force-pushed
the
issue-16114-rename-begin-unwind-2
branch
from
af05c95 to
20ccb2b
Compare
|
I've applied all changes. I've added a new commit for the renaming, because rebasing and squashing resulted in conflicts. If that's a problem I can try harder and produce a patch with fewer commits ;) |
fhahn
force-pushed
the
issue-16114-rename-begin-unwind-2
branch
from
20ccb2b to
88cc1e6
Compare
fhahn
force-pushed
the
issue-16114-rename-begin-unwind-2
branch
from
88cc1e6 to
3729004
Compare
fhahn
force-pushed
the
issue-16114-rename-begin-unwind-2
branch
from
3729004 to
d06f1aa
Compare
fhahn
force-pushed
the
issue-16114-rename-begin-unwind-2
branch
from
d06f1aa to
c8b767d
Compare
bors
added a commit
that referenced
this pull request
Sep 25, 2014
…r=alexcrichton This is a PR for #16114 and includes to following things: * Rename `begin_unwind` lang item to `fail_fmt` * Rename `core::failure::begin_unwind` to `fail_impl` * Rename `fail_` lang item to `fail`
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
feat: add space after specific keywords in completion fix rust-lang#17428. When completing some specific keywords, it would be convenient if r-a could automatically add a space afterwards. This PR implements this feature for the following keywords: - Visibility: `pub`, `pub(crate)`, `pub(super)`, `pub(in xxx)` - Pattern: `ref` / `mut` - Others: `unsafe` / `for` / `where`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for #16114 and includes to following things:
begin_unwindlang item tofail_fmtcore::failure::begin_unwindtofail_implfail_lang item tofail