Logstderr #1787
Closed
Logstderr #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes rustc diagnostics runtest updated to check stderr for errors
tests all write to stderr, so read stderr first to keep from blocking while reading stdout
Hopefully this addresses the root cause of the hangs when running make check on windows.
|
I added a new commit that will hopefully address the underlying issue simultaneous blocking reads. Thanks to brson for task::spawn_sched. |
|
Most recent update here seems to work on my windows machine. running try cycle now. if it passes, land it. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log to stderr instead of stdout.
This time with a possible workaround for the hang on windows when running tests.
Pushed once before in #1750, but caused #1769, so reverted.