Add a memoized function and use it throughout rustc
#17983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not super sold on the current syntax and would much prefer for this to be an attribute but that is not possible at the moment. |
| fn $name:ident( | ||
| $($param_name:ident: $param_ty:ty),* | ||
| ) -> $output_ty:ty $block:block, | ||
| $cache_map:expr, |
There was a problem hiding this comment.
Maybe these could be moved to be first, so that they're close to the function declaration (as it stands, one has to navigate around a possibly-long function body to find them, made harder by formatting it without indentation).
ghost
changed the title
ghost
changed the title
memoized function and use it throughout rustc
| pub fn memoized<T: Clone, U: Clone, M: MutableMap<T, U>>( | ||
| cache: &RefCell<M>, | ||
| f: &|&: T| -> U, | ||
| arg: T |
There was a problem hiding this comment.
I think it would be better for this argument to be before the closure, to improve readability.
|
@huonw Comments addressed. |
bors
added a commit
that referenced
this pull request
Oct 15, 2014
ghost
deleted the
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 29, 2024
…s, r=Veykril Consider field attributes when converting from tuple to named struct and the opposite Fixes rust-lang#17983. I tried to use the `SourceChangeBuilder::make_mut()` API, but it duplicated the attribute...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.