rustc: Fail immediately if linking returns status code != 0 #18239
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. |
|
I think this may actually be somewhat of a red herring, the Could you instead modify line 717 (above this change) to actually look at the status returned by |
|
Sure, will do. |
msiemens
changed the title
|
@alexcrichton I've added the changes you proposed. For that I reverted my original commit. Would it be better if I remove it completely? |
|
Thanks @msiemens! Could you squash the commits together (removing the revert), and also it may be helpful to print the command line that failed (just use the |
msiemens
force-pushed
the
fix-ice-rename-failed
branch
from
53cd39e to
b6e71da
Compare
msiemens
force-pushed
the
fix-ice-rename-failed
branch
from
b6e71da to
53ac852
Compare
|
Done. Is the new error message okay? |
|
(Sorry, to be clear, that was just a "for future reference" sort of comment, not a criticism or reason not to land the patch.) |
…puqv, r=davidbarsky chore: rename `salsa` to `ra_salsa` Laying some groundwork to start before I import the new Salsa crate. Here's why: 1. As part of the migration, `@darichey,` `@Wilfred,` and I will create new Salsa equivalents of the existing databases/query groups. We'll get them to compile crate-by-crate. 2. Once we wrote all equivalents of all queries, we'd start to refactor usage sites of the vendored Salsa to use the new Salsa databases. 3. Starting porting usage sites of old Salsa to the new Salsa. 4. Remove the vendored `ra_salsa`; declare victory.
If rustc fails to link a library (as described in #17951), it still tries to rename the non-existent file on Windows. I'm not sure how to test this as we'd have to reproduce a linking failure...
Closes #17951