build the crates guide #18251
Merged
build the crates guide #18251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
force-pushed
the
build_module_guide
branch
from
0474395 to
0c3ad8b
Compare
|
I don't understand this failure, it passes locally :/ I did notice it said 'rust,ignore' when it should have been 'notrust,ignore', but unsure why that makes it fail on bors but not here. I've updated it to be the right thing. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 27, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17555 I forgot to actually make the guide build :(