syntax::token module modernization #18365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need a rebase once some pending PRs land. |
brendanzab
force-pushed
the
token
branch
2 times, most recently
from
aaea492 to
28c1752
Compare
|
There are some mistakes with my rebase.... fixing... |
|
Fantastic cleanup @bjz, nice work! |
|
rebased |
bors
added a commit
that referenced
this pull request
Oct 29, 2014
[breaking-change]
(for syntax-extensions)
- Token variant identifiers have been converted to PascalCase for consistency with Rust coding standards
- Some free-functions in `syntax::token` have been converted to methods on `syntax::token::Token`:
- `can_begin_expr` -> `Token::can_begin_expr`
- `close_delimiter_for` -> `Token::get_close_delimiter`
- `is_lit` -> `Token::is_lit`
- `is_ident` -> `Token::is_ident`
- `is_path` -> `Token::is_path`
- `is_plain_ident` -> `Token::is_plain_ident`
- `is_lifetime` -> `Token::is_lifetime`
- `is_mutability` -> `Token::is_mutability`
- `to_binop` -> `Token::to_binop`
- `is_keyword` -> `Token::is_keyword`
- `is_any_keyword` -> `Token:is_any_keyword`
- `is_strict_keyword` -> `Token::is_strict_keyword`
- `is_reserved_keyword` -> `Token::is_reserved_keyword`
- `mtwt_token_eq` -> `Token::mtwt_eq`
- `token::Ident` now takes an enum instead of a boolean for clarity
- `token::{to_string, binop_to_string}` were moved to `pprust::{token_to_string, binop_to_string}`
|
Hmm |
|
I have a change incoming anyway. I would prefer to bundle it in with this one to reduce disruption downstream. |
|
Ok, @eddyb informs me that BSD is buggy, and ignored, so I'll let this one just go through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[breaking-change]
(for syntax-extensions)
syntax::tokenhave been converted to methods onsyntax::token::Token:can_begin_expr->Token::can_begin_exprclose_delimiter_for->Token::get_close_delimiteris_lit->Token::is_litis_ident->Token::is_identis_path->Token::is_pathis_plain_ident->Token::is_plain_identis_lifetime->Token::is_lifetimeis_mutability->Token::is_mutabilityto_binop->Token::to_binopis_keyword->Token::is_keywordis_any_keyword->Token:is_any_keywordis_strict_keyword->Token::is_strict_keywordis_reserved_keyword->Token::is_reserved_keywordmtwt_token_eq->Token::mtwt_eqtoken::Identnow takes an enum instead of a boolean for claritytoken::{to_string, binop_to_string}were moved topprust::{token_to_string, binop_to_string}