Rolling up PRs in the queue #18459
Merged
Rolling up PRs in the queue #18459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arenas write the value to memory and then return a non-aliasing reference to it. The returned reference can be mutable and can be coerced to an immutable one. [breaking-change]
Happened to be reading through
Closes rust-lang#15273 (I did not find how to get the identifier in the message :/) Also creates the span_help! macro associated with rust-lang#18126
This just adds some missing match cases in ty and trans Closes rust-lang#18412
The "/" was probably generated by a `gq` in vim.
This changes create_target_machine to correctly return a Result (Since the underlying LLVM function can fail and return NULL)
This common representation for delimeters should make pattern matching easier. Having a separate `token::DelimToken` enum also allows us to enforce the invariant that the opening and closing delimiters must be the same in `ast::TtDelimited`, removing the need to ensure matched delimiters when working with token trees.
We can simplify these usages due to the new delimiter representation. `Parser::expect_open_delim` has been added for convenience.
This commit adds the following impls:
impl<T> Deref<[T]> for Vec<T>
impl<T> DerefMut<[T]> for Vec<T>
impl Deref<str> for String
This commit also removes all duplicated inherent methods from vectors and
strings as implementations will now silently call through to the slice
implementation. Some breakage occurred at std and beneath due to inherent
methods removed in favor of those in the slice traits and std doesn't use its
own prelude,
cc rust-lang#18424
…nt group These lints are allow by default because they are sometimes too sensitive.
The type checker permits an array repeat expression of non-Copy type if the count is 1, but trans asserts on it prior to this change. Closes rust-lang#18425
|
|
alexcrichton
force-pushed
the
rollup
branch
2 times, most recently
from
78af9b4 to
4c1d4f7
Compare
Conflicts: src/libcollections/slice.rs src/libcore/failure.rs src/libsyntax/parse/token.rs src/test/debuginfo/basic-types-mut-globals.rs src/test/debuginfo/simple-struct.rs src/test/debuginfo/trait-pointers.rs
Conflicts: src/libsyntax/parse/parser.rs
Conflicts: src/libcollections/vec.rs
bors
added a commit
that referenced
this pull request
Oct 31, 2014
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Nov 28, 2024
feat: Use snippet placeholders for generated match arms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.