Support Sized bounds for associated types #18506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton |
nikomatsakis
force-pushed
the
assoc-type-bounds
branch
from
ad98066 to
553ce6b
Compare
| i += 1; | ||
| on_left | ||
| }); | ||
| pub fn split(self) -> (Vec<T>, Vec<T>, Vec<T>, Vec<T>) { |
There was a problem hiding this comment.
Can we make this return a struct instead?
|
r=me with that one fixed |
bounds like any other "type parameter".
from the definition (including Sized).
nikomatsakis
force-pushed
the
assoc-type-bounds
branch
from
9e57168 to
3c84e31
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also refactors associated types in various ways, most notably by moving the associated types defined in a trait into their own param space which replaces the associated-types hashmap (which is just removed). We should probably move the synthetic type parameters into yet another namespace, but that can wait.
Fixes #17921