Skip to content

Replace impl Copy fors with #[deriving(Copy)]s #19867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 19, 2014
Merged

Replace impl Copy fors with #[deriving(Copy)]s #19867

merged 23 commits into from
Dec 19, 2014

Conversation

japaric
Copy link
Member

@japaric japaric commented Dec 15, 2014

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@ftxqxd
Copy link
Contributor

ftxqxd commented Dec 15, 2014

Maybe this could also adjust the error message for the missing_copy_implementations lint if we’re going to standardise on #[deriving(Copy)] over impl Copy? (Currently, it recommends impl Copy.)

bors referenced this pull request Dec 16, 2014
@brson
rustup: Don't do verbose tarball extraction
349382b 
This creates an enormous amount of spew.
@japaric
Copy link
Member Author

japaric commented Dec 16, 2014

@alexcrichton rebased. re-r?

@japaric
Copy link
Member Author

japaric commented Dec 16, 2014

@alexcrichton another rebase! re-r?

@japaric
Copy link
Member Author

japaric commented Dec 17, 2014

@alexcrichton Another rebase \o/. re-r?

@vhbit vhbit mentioned this pull request Dec 17, 2014
Merged
@japaric japaric force-pushed the deriving-copy branch 5 times, most recently from 7364036 to 9307348 Compare December 19, 2014 12:06
bors added a commit that referenced this pull request Dec 19, 2014
@bors
auto merge of #19867 : japaric/rust/deriving-copy, r=acrichto
95c2ed3 
r? @alexcrichton
@bors bors merged commit f975b10 into rust-lang:master Dec 19, 2014
@japaric japaric deleted the deriving-copy branch December 20, 2014 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@japaric @rust-highfive @ftxqxd @bors @alexcrichton