Closes #13871 #20035
Closes #13871 #20035
Conversation
Removed copyrighted quotes. Closes rust-lang#13871
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Not copyrighted... |
|
Not copyrighted, but seems a bit bourgeois to me. Call me a misguided optimisation weenie, but I'm not sure I'm fond of ~2KB of every standard-library Rust program I make being dedicated to an easter egg 😀 |
|
Also, I remember being very confused at seeing this when a build of |
|
Even if the quotes were copyrighted (the one from Majora's Mask might be), this probably falls under fair use. |
|
Okay, so let's attack this from the other view-point... what possible value is added? |
|
This is from the runtime, so in applications where the extra 2kb is necessary (embedded), this will not be put into the executable. And where the extra 2kb is not needed, then its a fun easter egg. |
|
@sinistersnare Depends entirely on the mood of whoever gets Lovecraft quotes dumped at them when an |
|
@IDisposable can you change the commit message to remove mention of "copyrighted"? That's not the issue here (and I want to try and get this merged for the alpha...) |
|
+1 |
|
Done |
|
@IDisposable the commit message still incorrectly claims this is a copyright issue. |
|
I went ahead and did another one with a different commit message #20944 Thanks. |
Removed quotes. Closes #13871