std: Enforce Unicode in fmt::Writer #20377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @erickt (rust_highfive has picked a reviewer for you, use r? to override) |
|
This needs a rebase |
alexcrichton
force-pushed
the
issue-20352
branch
from
892a84b to
27c2c85
Compare
This commit is an implementation of [RFC 526][rfc] which is a change to alter the definition of the old `fmt::FormatWriter`. The new trait, renamed to `Writer`, now only exposes one method `write_str` in order to guarantee that all implementations of the formatting traits can only produce valid Unicode. [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/0526-fmt-text-writer.md One of the primary improvements of this patch is the performance of the `.to_string()` method by avoiding an almost-always redundant UTF-8 check. This is a breaking change due to the renaming of the trait as well as the loss of the `write` method, but migration paths should be relatively easy: * All usage of `write` should move to `write_str`. If truly binary data was being written in an implementation of `Show`, then it will need to use a different trait or an altogether different code path. * All usage of `write!` should continue to work as-is with no modifications. * All usage of `Show` where implementations just delegate to another should continue to work as-is. [breaking-change] Closes rust-lang#20352
alexcrichton
force-pushed
the
issue-20352
branch
from
27c2c85 to
e423fcf
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 2, 2015
|
@alexcrichton Was it deliberate to omit the |
|
Oops, I completely forgot about that! I'll try to add it soon. |
|
I’m personally still undecided whether it should be there, so I’ll leave the decision to you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an implementation of RFC 526 which is a change to alter
the definition of the old
fmt::FormatWriter. The new trait, renamed toWriter, now only exposes one methodwrite_strin order to guarantee that allimplementations of the formatting traits can only produce valid Unicode.
One of the primary improvements of this patch is the performance of the
.to_string()method by avoiding an almost-always redundant UTF-8 check. Thisis a breaking change due to the renaming of the trait as well as the loss of the
writemethod, but migration paths should be relatively easy:writeshould move towrite_str. If truly binary data wasbeing written in an implementation of
Show, then it will need to use adifferent trait or an altogether different code path.
write!should continue to work as-is with no modifications.Showwhere implementations just delegate to another shouldcontinue to work as-is.
[breaking-change]
Closes #20352