Final pre-alpha stabilization of: iter, ops, slice, collections #20560

aturon · 2015-01-05T05:51:59Z

Now that various language features have been rolled out and RFCs implemented, this PR takes a final stabilization pass over iter, ops, slice and collections.

Commit summaries copied below:

Final alpha stabilization of core::iter

This commit wraps up the adjustments to the iterator for recent language
changes.

Moves rposition from ExactSizeIterator to IteratorExt using a
where clause, thereby removing the ExactSizeIterator: DoubleEndedIterator constraint.
Merges MutableDoubleEndedIterator into IteratorExt, renaming
reverse_ to reverse_in_place.
Merges IteratorOrdExt, IteratorCloneExt and CloneIteratorExt
into IteratorExt using where clauses.

Marks as #[stable]:

the iter module itself
FromIterator, Extend
Iterator, IteratorExt
map
filter
filter_map
skip_while
take_while
scan
flat_map
inspect
collect
fold
all
any
find
rposition
max, min
Various adapter types related to the above methods

Because of the trait merging, this is a:

[breaking-change]

Stabilize core::ops

This commit marks as stable those parts of core::ops that are in their
final planned form: Drop, all of the mathematical operators (Add,
Sub, etc), Deref/DerefMut. It leaves the Index*, Slice* and
Fn* traits unstable, as they are still undergoing active changes.

Final alpha stabilization of std::slice

Marks as #[stable]:

Various iterator structs for stable methods, e.g. Chunks and
Windows.
The SliceExt trait itself.

Stabilize collection modules

The earlier collections stabilization did not cover the modules
themselves. This commit marks as stable those modules whose types have
been stabilized.

Stabilization of impls and fallout from stabilization

Stabilizes impls of now-stable traits.

rust-highfive · 2015-01-05T05:52:02Z

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

aturon · 2015-01-05T05:52:06Z

r? @alexcrichton

aturon · 2015-01-05T05:52:47Z

(We should probably wait to land this until we've had a chance to discuss Iterator again.)

Gankra · 2015-01-05T05:59:35Z

src/liballoc/arc.rs

@@ -418,7 +418,7 @@ impl<T: Sync + Send> Clone for Weak<T> {
 }

 #[unsafe_destructor]
-#[experimental = "Weak pointers may not belong in this module."]
+#[stable]


Any notes on this call?

Don't read anything into the #[stable] here other than: if we have Weak, we'll keep the Drop impl.

aturon · 2015-01-05T06:14:15Z

@gankro pushed a revision marking the correct hash_map modules. I think the markers within libcollections were already OK. Double-check my work?

alexcrichton · 2015-01-05T07:08:41Z

src/libcore/iter.rs

    fn size_hint(&self) -> (uint, Option<uint>) { (0, None) }
 }

 /// Conversion from an `Iterator`
-#[unstable = "may be replaced by a more general conversion trait"]
+#[stable]
 pub trait FromIterator<A> {
    /// Build a container with elements from an external iterator.
    fn from_iter<T: Iterator<Item=A>>(iterator: T) -> Self;
 }


This seems slightly odd to still have a type parameter now that Item is an associated type, but I suppose T: Iterator doesn't tell you much and you need to write down the Item type somewhere.

Just confirming.

This is desired to allow types to be created (or extended) via iterators from multiple items. For example, String can be extended by char or &str iterators.

alexcrichton · 2015-01-05T07:13:22Z

This looks great to me, this is all really falling into place!

Gankra · 2015-01-05T07:19:08Z

Also should we explicitly mark the other modules as unstable with a reason?

alexcrichton · 2015-01-05T07:31:07Z

This should also add #![stable] to the slice module itself.

This commit wraps up the adjustments to the iterator for recent language changes. * Moves `rposition` from `ExactSizeIterator` to `IteratorExt` using a `where` clause, thereby removing the `ExactSizeIterator: DoubleEndedIterator` constraint. * Merges `MutableDoubleEndedIterator` into `IteratorExt`, renaming `reverse_` to `reverse_in_place`. * Merges `IteratorOrdExt`, `IteratorCloneExt` and `CloneIteratorExt` into `IteratorExt` using `where` clauses. Marks as `#[stable]`: * the `iter` module itself * `FromIterator`, `Extend` * `Iterator`, `IteratorExt` * `map` * `filter` * `filter_map` * `skip_while` * `take_while` * `scan` * `flat_map` * `inspect` * `collect` * `fold` * `all` * `any` * `find` * `rposition` * `max`, `min` * Various adapter types related to the above methods Because of the trait merging, this is a: [breaking-change]

This commit marks as stable those parts of `core::ops` that are in their final planned form: `Drop`, all of the mathematical operators (`Add`, `Sub`, etc), `Deref`/`DerefMut`. It leaves the `Index*`, `Slice*` and `Fn*` traits unstable, as they are still undergoing active changes.

Marks as `#[stable]`: * Various iterator structs for stable methods, e.g. `Chunks` and `Windows`. * The `SliceExt` trait itself.

The earlier collections stabilization did not cover the modules themselves. This commit marks as stable those modules whose types have been stabilized.

aturon · 2015-01-05T22:09:37Z

@alexcrichton updated. After a bunch of discussion on the topic, I think we should move forward stabilizing Iterator as in this PR. r?

alexcrichton · 2015-01-05T22:14:27Z

Looks like rust-installer was reverted, but r=me otherwise

aturon · 2015-01-05T22:20:30Z

I hate submodules 💢

Conflicts: src/libcollections/slice.rs src/libcore/iter.rs src/libstd/sync/mpsc/mod.rs src/libstd/sync/rwlock.rs

alexcrichton · 2015-01-06T15:18:03Z

Landed in #20610

rust-highfive assigned pcwalton Jan 5, 2015

rust-highfive assigned alexcrichton and unassigned pcwalton Jan 5, 2015

Gankra reviewed Jan 5, 2015
View reviewed changes

aturon force-pushed the stab-2-iter-ops-slice branch from c11d268 to ee5109b Compare January 5, 2015 06:13

aturon mentioned this pull request Jan 5, 2015

Stabilization metabug: 1.0-alpha #19260

Closed

alexcrichton reviewed Jan 5, 2015
View reviewed changes

aturon added 2 commits January 5, 2015 14:01

aturon force-pushed the stab-2-iter-ops-slice branch from ee5109b to 5371ae2 Compare January 5, 2015 22:08

aturon added 2 commits January 5, 2015 14:08

Final alpha stabilization of std::slice

121f6c6

Marks as `#[stable]`: * Various iterator structs for stable methods, e.g. `Chunks` and `Windows`. * The `SliceExt` trait itself.

Stabilize collection modules

cb765ce

The earlier collections stabilization did not cover the modules themselves. This commit marks as stable those modules whose types have been stabilized.

aturon force-pushed the stab-2-iter-ops-slice branch from 5371ae2 to c6f4a03 Compare January 5, 2015 22:26

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 6, 2015

rollup merge of rust-lang#20560: aturon/stab-2-iter-ops-slice

2e883a5

Conflicts: src/libcollections/slice.rs src/libcore/iter.rs src/libstd/sync/mpsc/mod.rs src/libstd/sync/rwlock.rs

Stabilization of impls and fallout from stabilization

107fe6e

aturon force-pushed the stab-2-iter-ops-slice branch from c6f4a03 to 107fe6e Compare January 6, 2015 08:17

alexcrichton closed this Jan 6, 2015

ascherdavid mentioned this pull request Jan 10, 2015

Implement the rust-style review flag davidascher/issue-handler#20

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final pre-alpha stabilization of: iter, ops, slice, collections #20560

Final pre-alpha stabilization of: iter, ops, slice, collections #20560

aturon commented Jan 5, 2015

rust-highfive commented Jan 5, 2015

aturon commented Jan 5, 2015

aturon commented Jan 5, 2015

Gankra Jan 5, 2015

aturon Jan 5, 2015

aturon commented Jan 5, 2015

alexcrichton Jan 5, 2015

aturon Jan 5, 2015

alexcrichton commented Jan 5, 2015

Gankra commented Jan 5, 2015

alexcrichton commented Jan 5, 2015

aturon commented Jan 5, 2015

alexcrichton commented Jan 5, 2015

aturon commented Jan 5, 2015

alexcrichton commented Jan 6, 2015

Final pre-alpha stabilization of: iter, ops, slice, collections #20560

Final pre-alpha stabilization of: iter, ops, slice, collections #20560

Conversation

aturon commented Jan 5, 2015

Final alpha stabilization of core::iter

Stabilize core::ops

Final alpha stabilization of std::slice

Stabilize collection modules

Stabilization of impls and fallout from stabilization

rust-highfive commented Jan 5, 2015

aturon commented Jan 5, 2015

aturon commented Jan 5, 2015

Gankra Jan 5, 2015

Choose a reason for hiding this comment

aturon Jan 5, 2015

Choose a reason for hiding this comment

aturon commented Jan 5, 2015

alexcrichton Jan 5, 2015

Choose a reason for hiding this comment

aturon Jan 5, 2015

Choose a reason for hiding this comment

alexcrichton commented Jan 5, 2015

Gankra commented Jan 5, 2015

alexcrichton commented Jan 5, 2015

aturon commented Jan 5, 2015

alexcrichton commented Jan 5, 2015

aturon commented Jan 5, 2015

alexcrichton commented Jan 6, 2015