Fix documentation: aliases may not be used in loop constructs. #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Funny thing: while you're absolutely right that the document is inconsistent (and rustboot errs on the side of not allowing aliases), I have a hunch that they can be supported in those contexts, due to the way they're implemented. The edits you're making here are essentially covering over the tracks of some wishful thinking I've not yet managed to work out rules to handle. I suppose for the sake of clarity I'll fold them in, and file a bug suggesting we figure out how to support aliases "someday". |
|
Integrated. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Use nightlies for iOS and rumprun
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
dlrobertson
pushed a commit
to dlrobertson/rust
that referenced
this pull request
Nov 29, 2018
Enhance discussion of deprecated attribute
rchaser53
pushed a commit
to rchaser53/rust
that referenced
this pull request
Jan 19, 2019
Update a few parts of the readme
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Oct 26, 2020
djtech-dev
pushed a commit
to djtech-dev/rust
that referenced
this pull request
Dec 9, 2021
…inking Add feature to disable linking to libffi
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Add tests for rust-lang#564, rust-lang#208 and rust-lang#87. Unfortunately, it looks like there are still issues with with how we are encoding panic threads and dynamic objects which are causing two of the test cases to fail.
carolynzech
added a commit
to celinval/rust-dev
that referenced
this pull request
Dec 13, 2024
Fixing some typos. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. Co-authored-by: Carolyn Zech <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that "aliases can only be declared as arguments in a function or iterator signature, bound to the lifetime of a stack frame", but example code in Ref.Stmt.For and Ref.Stmt.Foreach use aliases within loop statements, which is contradictory. Rustboot validly rejects aliases in that position. This change removes the ambersand sigils to fix the examples.