Make error code registration work again. #19624 #21289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brson
force-pushed
the
errorcodes
branch
3 times, most recently
from
d910a17 to
ac6d6d9
Compare
|
The tidy script now also prints the highest error code. |
brson
force-pushed
the
errorcodes
branch
3 times, most recently
from
deacf5f to
ab410cd
Compare
brson
force-pushed
the
errorcodes
branch
2 times, most recently
from
2df3c3d to
56f77ec
Compare
|
@bors: r+ 7528c2c |
|
⌛ Testing commit 876b266 with merge 0a1e3ef... |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 21, 2015
This does the bare minimum to make registration of error codes work again. After this patch, every call to `span_err!` with an error code gets that error code validated against a list in that crate and a new tidy script `errorck.py` validates that no error codes are duplicated globally. There are further improvements to be made yet, detailed in rust-lang#19624. r? @nikomatsakis
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: retry |
|
⌛ Testing commit 876b266 with merge d6a75a5... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: retry |
1 similar comment
|
@bors: retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the bare minimum to make registration of error codes work again. After this patch, every call to
span_err!with an error code gets that error code validated against a list in that crate and a new tidy scripterrorck.pyvalidates that no error codes are duplicated globally.There are further improvements to be made yet, detailed in #19624.
r? @nikomatsakis