-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[Rustbook] add next/prev section links in the book -- using js #21494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
@@ -1,4 +1,4 @@ | |||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | |||
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't increment these, they're useless.
Would you be able to build rustbook with these changes and host a copy for us to review the changes in production? |
Sure here you go http://jatinn.github.io/rust/README.html |
This doesn't work if I visit: http://jatinn.github.io/rust/ |
Otherwise this looks great! |
Although I would appreciate some comments noting what this code is for, and maybe desciribing the high-level logic ("search the TOC for this URL, and then grab the predecessor/successor, and toss them at the bottom of the page") |
changes made |
@jatinn one last nit: we have a style guide for comments to be |
r? @gankro |
r+ e371d rollup |
Thanks a ton! |
Added javascript code to insert next/prev links in the rust book. Related Issue - rust-lang#20835
fUCK |
@bors r+ e371d rollup |
Added javascript code to insert next/prev links in the rust book. Related Issue - rust-lang#20835
Added javascript code to insert next/prev links in the rust book.
Related Issue - #20835