Skip to content

[Rustbook] add next/prev section links in the book -- using js #21494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2015

Conversation

jatinn
Copy link
Contributor

@jatinn jatinn commented Jan 22, 2015

Added javascript code to insert next/prev links in the rust book.
Related Issue - #20835

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

Thanks @jatinn !

@gankro , what do you think of this PR?

@@ -1,4 +1,4 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't increment these, they're useless.

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

Would you be able to build rustbook with these changes and host a copy for us to review the changes in production?

@jatinn
Copy link
Contributor Author

jatinn commented Jan 23, 2015

Sure here you go http://jatinn.github.io/rust/README.html
Also should i go back and change the copyright year back to 2014? I thought in the contribution notes it mentioned updating it.

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

@jatinn copyright stuff is in flux. See #21481 for discussion

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

This doesn't work if I visit: http://jatinn.github.io/rust/

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

Otherwise this looks great!

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

Although I would appreciate some comments noting what this code is for, and maybe desciribing the high-level logic ("search the TOC for this URL, and then grab the predecessor/successor, and toss them at the bottom of the page")

@jatinn
Copy link
Contributor Author

jatinn commented Jan 23, 2015

changes made

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

@jatinn one last nit: we have a style guide for comments to be // style. Change that, squash the commits into one, and r=me

@jatinn
Copy link
Contributor Author

jatinn commented Jan 23, 2015

r? @gankro

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

r+ e371d rollup

@Gankra
Copy link
Contributor

Gankra commented Jan 23, 2015

Thanks a ton!

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015
Added javascript code to insert next/prev links in the rust book.
Related Issue - rust-lang#20835
@Gankra
Copy link
Contributor

Gankra commented Jan 29, 2015

fUCK

@Gankra
Copy link
Contributor

Gankra commented Jan 29, 2015

@bors r+ e371d rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 30, 2015
Added javascript code to insert next/prev links in the rust book.
Related Issue - rust-lang#20835
@alexcrichton alexcrichton merged commit e371d23 into rust-lang:master Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants