Remove get method from InternedString by GuillaumeGomez · Pull Request #21505 · rust-lang/rust

GuillaumeGomez · 2015-01-22T11:31:20Z

It's in order to make the code more homogeneous.

rust-highfive · 2015-01-22T11:31:35Z

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

GuillaumeGomez · 2015-01-24T18:47:36Z

No feedback ?

GuillaumeGomez · 2015-01-24T20:25:38Z

r? @alexcrichton

alexcrichton · 2015-01-25T02:57:56Z

Thanks! The Str trait currently isn't necessarily meant for implementations as it may not survive stabilization of the std::str module. The get method can probably be removed entirely in favor of the Deref implementation, however.

GuillaumeGomez · 2015-01-25T10:02:55Z

Okay ! Then do I just remove the Str trait and the get method ?

alexcrichton · 2015-01-26T08:37:26Z

Yeah that should work just fine.

alexcrichton · 2015-02-02T03:45:03Z

@bors: r+ 4e53266

Feel free to ping the PR when it gets updated, sadly github doesn't send out notifications on a force push!

GuillaumeGomez · 2015-02-02T08:38:10Z

My bad, I didn't think about that ! Thanks !

bors · 2015-02-02T09:34:57Z

⌛ Testing commit 4e53266 with merge 4f559b0...

bors · 2015-02-02T09:40:59Z

💔 Test failed - auto-mac-64-opt

GuillaumeGomez · 2015-02-02T23:25:43Z

@alexcrichton: it should be ready now !

alexcrichton · 2015-02-03T00:18:40Z

Thanks! In general though you should never need to call deref manually. If for example you have foo.deref().bar() you can actually just call it foo.bar(). If you have foo.deref() then you can replace it with &foo[] (in the case of slicing) or &*foo in the case of a raw pointer.

GuillaumeGomez · 2015-02-03T08:56:00Z

I found this writing:

foo.deref()

beautifuler than this one:

&*foo

But I can change it if you prefer ! At least I'll rebase on the master to solve merge conflicts.

alexcrichton · 2015-02-03T16:56:07Z

I think that deref coercions may be in a snapshot now so instead of foo.deref() I believe you can pass &foo (as opposed to &*foo)

GuillaumeGomez · 2015-02-04T00:10:42Z

@alexcrichton: It's (finally) ready to be merged !

alexcrichton · 2015-02-04T06:03:44Z

@bors: r+ d6bfb9a

bors · 2015-02-04T06:35:23Z

⌛ Testing commit d6bfb9a with merge 4495d7d...

bors · 2015-02-04T06:40:11Z

💔 Test failed - auto-linux-64-x-android-t

alexcrichton · 2015-02-04T06:41:32Z

@bors: retry

bors · 2015-02-04T15:32:03Z

⌛ Testing commit d6bfb9a with merge 2ba5a04...

bors · 2015-02-04T15:49:42Z

💔 Test failed - auto-mac-64-nopt-t

alexcrichton · 2015-02-04T16:43:31Z

@GuillaumeGomez the most recent failure is the more relevant one.

Also, in light of #21916 you may want to replace as many &foo[] with &foo as possible to help prevent churn when [] is switched to [..].

GuillaumeGomez · 2015-02-04T18:02:52Z

@alexcrichton: Ok ! Just like you said. I update my code and let's try again !

GuillaumeGomez · 2015-02-06T21:03:03Z

Tests worked. @alexcrichton, r+ please ?

alexcrichton · 2015-02-06T21:46:39Z

@GuillaumeGomez could you squash some of these commits together as well? Mainly just the "fix foo" commits which don't necessarily need to exist.

Fixes run build error Fix test failure Fix tests' errors

GuillaumeGomez · 2015-02-06T21:55:44Z

Done !

alexcrichton · 2015-02-06T21:56:12Z

@bors: r+ a2e01c6

bors · 2015-02-06T23:25:54Z

⌛ Testing commit a2e01c6 with merge bfe1453...

bors · 2015-02-06T23:30:16Z

💔 Test failed - auto-linux-32-opt

alexcrichton · 2015-02-06T23:30:48Z

@bors: retry

bors · 2015-02-07T02:04:47Z

⌛ Testing commit a2e01c6 with merge 7ebf9bc...

It's in order to make the code more homogeneous.

bors · 2015-02-07T04:14:20Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

See rust-lang/rust#21505

…yarn/editors/code/lodash-4.17.23 Bump lodash from 4.17.21 to 4.17.23 in /editors/code

rust-highfive assigned sfackler Jan 22, 2015

rust-highfive assigned alexcrichton and unassigned sfackler Jan 24, 2015

GuillaumeGomez changed the title ~~Add Str trait to InternedString, set get method deprecated~~ Remove get method from InternedString Feb 4, 2015

GuillaumeGomez added 12 commits February 6, 2015 11:59

Replace the get method by the deref one on InternedString

d58c0a7

Update HEAD:master

12f1f4c

Libsyntax has been updated

8b12d3d

librustc has been updated

664c41b

librustc_borrowck has been updated

0f09021

librustc_typeck has been updated

4b6632d

librustc_resolve has been updated

1ff6e53

librustc_trans has been updated

b009778

librustc_driver has been updated

93fe5c8

Update to last version, remove "[]" as much as possible

7b973ba

Remove getenv warning

b0b4136

Fix infinite loop error

9e20035

librustdoc has been updated

a2e01c6

Fixes run build error Fix test failure Fix tests' errors

bors added a commit that referenced this pull request Feb 7, 2015

Auto merge of #21505 - GuillaumeGomez:interned_string, r=alexcrichton

7ebf9bc

It's in order to make the code more homogeneous.

bors merged commit a2e01c6 into rust-lang:master Feb 7, 2015

GuillaumeGomez deleted the interned_string branch February 7, 2015 11:42

renato-zannon added a commit to renato-zannon/racer that referenced this pull request Feb 8, 2015

token::InternedString no longer has a .get() method

cd75428

See rust-lang/rust#21505

renato-zannon mentioned this pull request Feb 8, 2015

token::InternedString no longer has a .get() method racer-rust/racer#143

Closed

Potpourri mentioned this pull request Feb 8, 2015

Fix gfx_macros gfx-rs/gfx#546

Merged

lnicola pushed a commit to lnicola/rust that referenced this pull request Feb 23, 2026

Merge pull request rust-lang#21505 from rust-lang/dependabot/npm_and_…

9884941

…yarn/editors/code/lodash-4.17.23 Bump lodash from 4.17.21 to 4.17.23 in /editors/code

Uh oh!

Conversation

GuillaumeGomez commented Jan 22, 2015

Uh oh!

rust-highfive commented Jan 22, 2015

Uh oh!

GuillaumeGomez commented Jan 24, 2015

Uh oh!

GuillaumeGomez commented Jan 24, 2015

Uh oh!

alexcrichton commented Jan 25, 2015

Uh oh!

GuillaumeGomez commented Jan 25, 2015

Uh oh!

alexcrichton commented Jan 26, 2015

Uh oh!

alexcrichton commented Feb 2, 2015

Uh oh!

GuillaumeGomez commented Feb 2, 2015

Uh oh!

bors commented Feb 2, 2015

Uh oh!

bors commented Feb 2, 2015

Uh oh!

GuillaumeGomez commented Feb 2, 2015

Uh oh!

alexcrichton commented Feb 3, 2015

Uh oh!

GuillaumeGomez commented Feb 3, 2015

Uh oh!

alexcrichton commented Feb 3, 2015

Uh oh!

GuillaumeGomez commented Feb 4, 2015

Uh oh!

alexcrichton commented Feb 4, 2015

Uh oh!

bors commented Feb 4, 2015

Uh oh!

bors commented Feb 4, 2015

Uh oh!

alexcrichton commented Feb 4, 2015

Uh oh!

bors commented Feb 4, 2015

Uh oh!

bors commented Feb 4, 2015

Uh oh!

alexcrichton commented Feb 4, 2015

Uh oh!

GuillaumeGomez commented Feb 4, 2015

Uh oh!

GuillaumeGomez commented Feb 6, 2015

Uh oh!

alexcrichton commented Feb 6, 2015

Uh oh!

GuillaumeGomez commented Feb 6, 2015

Uh oh!

alexcrichton commented Feb 6, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

alexcrichton commented Feb 6, 2015

Uh oh!

bors commented Feb 7, 2015

Uh oh!

bors commented Feb 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants