Clean up isize, usize. Don't bench allocation but formatting.
#21537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #[bench] | ||
| fn format_bin(b: &mut Bencher) { | ||
| let mut rng = weak_rng(); | ||
| b.iter(|| { format!("{:b}", rng.gen::<uint>()); }) | ||
| b.iter(|| { let _ = write!(&mut NullWriter, "{:b}", rng.gen::<u32>()); }) |
There was a problem hiding this comment.
Is there a reason to feed this into a let and not just return it from the closure?
|
r=me with @gankro's comment |
|
@alexcrichton Now, Gankro's nits addressed and fixed the function names from |
|
@bors: r+ d909dad Thanks! |
|
⌛ Testing commit d909dad with merge ba3f67c... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
|
⌛ Testing commit d909dad with merge 796d009... |
bors
added a commit
that referenced
this pull request
Jan 24, 2015
r? @alexcrichton Part of #20792 that wasn't done in your commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton
Part of #20792 that wasn't done in your commit.