Skip to content

Suppress space after idents with "ModName" style in serialization of exported macros. #21542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2015
Merged

Suppress space after idents with "ModName" style in serialization of exported macros. #21542

merged 3 commits into from
Jan 24, 2015

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Jan 23, 2015

... so that super::foo gets serialized as super:: foo, rather than super :: foo.

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks! Can you add a test for this as well?

@vadimcn vadimcn force-pushed the fix-exported-macro-paths branch 3 times, most recently from 6994a01 to 27a261b Compare January 23, 2015 07:00
@vadimcn vadimcn force-pushed the fix-exported-macro-paths branch from 6994a01 to 5c344d3 Compare January 23, 2015 07:05
@vadimcn
Copy link
Contributor Author

vadimcn commented Jan 23, 2015

Done. r?

@sfackler
Copy link
Member

cc #20923

@alexcrichton
Copy link
Member

Looks like there are some tidy errors, otherwise r=me, thanks!

@vadimcn
Copy link
Contributor Author

vadimcn commented Jan 24, 2015

ok, looks like tidy is happy now

@alexcrichton
Copy link
Member

@bors: r+ f09c680

bors added a commit that referenced this pull request Jan 24, 2015
@bors
Auto merge of #21542 - vadimcn:fix-exported-macro-paths, r=alexcrichton
0430a43 
... so that `super::foo` gets serialized as `super:: foo`, rather than `super :: foo`.
@bors
Copy link
Collaborator

bors commented Jan 24, 2015

⌛ Testing commit f09c680 with merge 0430a43...

@bors
Copy link
Collaborator

bors commented Jan 24, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit f09c680 into rust-lang:master Jan 24, 2015
@vadimcn vadimcn deleted the fix-exported-macro-paths branch January 27, 2015 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vadimcn @rust-highfive @alexcrichton @sfackler @bors @pcwalton