Allow quantification of lifetimes outside the self type in where clauses #21961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch looks good, I think it is wise to prefer the hack for the time being. |
|
This looks good but don't we want some tests of some kind? |
|
(PS sorry it took me so long to review, I didn't notice this for a while) |
|
ah, crap, I forgot to |
|
rebased and added tests |
|
Seems reasonable. I'd sort of like a test that shows that the correct requirements are being put onto the caller (e.g. a compile-fail test where the requirement is |
|
@nikomatsakis test added |
|
@bors r+ c50a8f930245aa2a5a52e230c68a298c84f5a8a1 |
|
⌛ Testing commit c50a8f9 with merge 5f2ab7f... |
|
💔 Test failed - auto-mac-32-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20022
r? @nikomatsakis