-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Import rust-guidelines #22331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import rust-guidelines #22331
Conversation
bbae71d
to
f94ce45
Compare
Awesome! One question: I've never been overly fond of "Rust Guidelines" for the title of this, although now that the "Guides" are not a thing it's a little better. Any bikeshedding ideas? |
PEP 8 is called "Style guide for python code". So "Style Guide"? |
OK, sounds fine to me. Would you be willing to do the rename now, before we bring it in? |
f94ce45
to
96bea5e
Compare
@aturon done, I think. 😄 |
*~ | ||
*.bak | ||
*.swp | ||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably be left out
@alexcrichton nice, thanks! Fixed. |
@@ -0,0 +1,3 @@ | |||
*~ | |||
*.bak | |||
*.swp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
er I meant could this whole file be remove?
r=me with one small nit I noticed that this is not actually linked from any location, but I think that's a good thing for now. We should take some more time to flesh out these documents before we're ready to link to them from the main page. |
re links: exactly |
re links: exactly what i was thinking. |
Fixes #19315
r? @aturon