Skip to content

Rename std::failure to std::panicking #22347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2015
Merged

Rename std::failure to std::panicking #22347

merged 1 commit into from
Feb 16, 2015

Conversation

iKevinY
Copy link
Contributor

@iKevinY iKevinY commented Feb 14, 2015

Rename libstd/failure.rs to libstd/panicking.rs and on_fail to on_panic. Closes #22306.

@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@iKevinY
Copy link
Contributor Author

iKevinY commented Feb 14, 2015

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned huonw Feb 14, 2015
@brson
Copy link
Contributor

brson commented Feb 15, 2015

@bors: r+ 1e01f7f rollup

Not leaving any deprecated functions in place. Hoping it won't have much fallout since this is a minor unstable runtime API.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 15, 2015
Rename `libstd/failure.rs` to `libstd/panicking.rs` and `on_fail` to `on_panic`. Closes rust-lang#22306.
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 15, 2015
 Rename `libstd/failure.rs` to `libstd/panicking.rs` and `on_fail` to `on_panic`. Closes rust-lang#22306.
@bors bors merged commit 1e01f7f into rust-lang:master Feb 16, 2015
@iKevinY iKevinY deleted the std-lib-panicking branch February 16, 2015 03:53
@brson
Copy link
Contributor

brson commented Feb 17, 2015

breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect naming in std::failure
5 participants